From 8741997982c969745fef5aa322992515ea749386 Mon Sep 17 00:00:00 2001 From: "titzer@chromium.org" Date: Thu, 14 Aug 2014 09:52:21 +0000 Subject: [PATCH] Enable more tests for simplified lowering after assuming signed for word32. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/461933002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/cctest/compiler/test-simplified-lowering.cc | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/test/cctest/compiler/test-simplified-lowering.cc b/test/cctest/compiler/test-simplified-lowering.cc index 1ede771..3b5173f 100644 --- a/test/cctest/compiler/test-simplified-lowering.cc +++ b/test/cctest/compiler/test-simplified-lowering.cc @@ -1011,17 +1011,13 @@ void CheckChangeInsertion(IrOpcode::Value expected, MachineType from, TEST(InsertBasicChanges) { - if (false) { - // TODO(titzer): these changes need the output to have the right type. - CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, kRepFloat64, - kTypeInt32); - CheckChangeInsertion(IrOpcode::kChangeFloat64ToUint32, kRepFloat64, - kTypeUint32); - CheckChangeInsertion(IrOpcode::kChangeTaggedToInt32, kRepTagged, - kTypeInt32); - CheckChangeInsertion(IrOpcode::kChangeTaggedToUint32, kRepTagged, - kTypeUint32); - } + CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, kRepFloat64, + kTypeInt32); + CheckChangeInsertion(IrOpcode::kChangeFloat64ToUint32, kRepFloat64, + kTypeUint32); + CheckChangeInsertion(IrOpcode::kChangeTaggedToInt32, kRepTagged, kTypeInt32); + CheckChangeInsertion(IrOpcode::kChangeTaggedToUint32, kRepTagged, + kTypeUint32); CheckChangeInsertion(IrOpcode::kChangeFloat64ToTagged, kRepFloat64, kRepTagged); -- 2.7.4