From 872c24972e19bb9315709279d1b46765646ac996 Mon Sep 17 00:00:00 2001 From: HyunJin Park Date: Mon, 19 Oct 2015 15:06:28 +0900 Subject: [PATCH] Revert "[Account] - Removing TODOs from the Account module" - Account module of Web TCT has 43 fail issues. This reverts commit 1edd55c502bfa93753232f9e7e7898a89cf1d315. Change-Id: Ib609f01c2c37f2880ce11dc95e47313e304c2510 --- src/account/account_api.js | 6 ++++++ src/account/account_manager.cc | 10 ++-------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/account/account_api.js b/src/account/account_api.js index 044d8cde..6c1c84c4 100755 --- a/src/account/account_api.js +++ b/src/account/account_api.js @@ -115,6 +115,8 @@ Account.prototype.getExtendedData = function() { } ]); + // TODO handling exceptions + native_.call('Account_getExtendedData', { accountId: this.id }, function(result) { if (native_.isFailure(result)) { @@ -254,6 +256,8 @@ AccountManager.prototype.getAccounts = function() { { name: 'applicationId', type: types_.STRING, optional: true, nullable: true } ]); + // TODO handling exceptions + native_.call('AccountManager_getAccounts', { applicationId: args.applicationId @@ -311,6 +315,8 @@ AccountManager.prototype.getProviders = function() { { name: 'capability', type: types_.STRING, optional: true, nullable: true } ]); + // TODO handling exceptions + native_.call( 'AccountManager_getProviders', { capability: args.capability diff --git a/src/account/account_manager.cc b/src/account/account_manager.cc index 4d1043df..409ac752 100755 --- a/src/account/account_manager.cc +++ b/src/account/account_manager.cc @@ -17,7 +17,6 @@ #include "account/account_manager.h" #include -#include #include "common/logger.h" #include "common/scope_exit.h" @@ -336,13 +335,8 @@ bool AccountManager::ConvertProviderToObject(account_type_h provider, out["applicationId"] = picojson::value(provider_id); free(provider_id); - std::string language("default"); - std::locale loc(""); - if (loc.name().length() >= 5) { - language = loc.name().substr(0, 5); - } - - ret = account_type_get_label_by_locale(provider, language.c_str(), &display_name); + // TODO: Which label should be returned? + ret = account_type_get_label_by_locale(provider, "default", &display_name); if (ret == ACCOUNT_ERROR_NONE) { out["displayName"] = picojson::value(display_name); free(display_name); -- 2.34.1