From 86d3c9fd1fd70760e417b3efacc29c0a4cc6194b Mon Sep 17 00:00:00 2001 From: Stefan Granitz Date: Wed, 10 Jul 2019 16:00:03 +0000 Subject: [PATCH] [CMake][NFC] Polish comments in AddLLDB.cmake llvm-svn: 365650 --- lldb/cmake/modules/AddLLDB.cmake | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake index d53dab6..d420a12 100644 --- a/lldb/cmake/modules/AddLLDB.cmake +++ b/lldb/cmake/modules/AddLLDB.cmake @@ -176,18 +176,22 @@ function(lldb_append_link_flags target_name new_link_flags) set_target_properties(${target_name} PROPERTIES LINK_FLAGS ${new_link_flags}) endfunction() +# The test suite relies on finding LLDB.framework binary resources in the +# build-tree. Remove them before installing to avoid collisions with their +# own install targets. function(lldb_add_to_buildtree_lldb_framework name subdir) # Destination for the copy in the build-tree. While the framework target may # not exist yet, it will exist when the generator expression gets expanded. set(copy_dest "$/../../../${subdir}") - # Copy into the framework's Resources directory for testing. + # Copy into the given subdirectory for testing. add_custom_command(TARGET ${name} POST_BUILD COMMAND ${CMAKE_COMMAND} -E copy $ ${copy_dest} COMMENT "Copy ${name} to ${copy_dest}" ) endfunction() +# Add extra install steps for dSYM creation and stripping for the given target. function(lldb_add_post_install_steps_darwin name install_prefix) if(NOT APPLE) message(WARNING "Darwin-specific functionality; not currently available on non-Apple platforms.") @@ -219,7 +223,7 @@ function(lldb_add_post_install_steps_darwin name install_prefix) endif() endif() - # Generate dSYM in symroot + # Generate dSYM set(dsym_name ${output_name}.dSYM) if(is_framework) set(dsym_name ${output_name}.framework.dSYM) -- 2.7.4