From 86a62d0da3454732fe0e762e9716a4cefb2ecf2c Mon Sep 17 00:00:00 2001 From: "yangguo@chromium.org" Date: Thu, 1 Sep 2011 11:28:10 +0000 Subject: [PATCH] Added check for trailing whitespaces and corrected existing violations. Review URL: http://codereview.chromium.org/7826007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- benchmarks/crypto.js | 2 +- benchmarks/earley-boyer.js | 50 ++++++++++++------------- benchmarks/regexp.js | 6 +-- build/all.gyp | 2 +- include/v8.h | 4 +- src/d8.js | 2 +- src/macros.py | 2 +- test/es5conform/es5conform.status | 6 +-- test/mjsunit/array-constructor.js | 8 ++-- test/mjsunit/array-iteration.js | 12 +++--- test/mjsunit/array-sort.js | 2 +- test/mjsunit/bugs/618.js | 4 +- test/mjsunit/bugs/bug-618.js | 6 +-- test/mjsunit/compiler/global-accessors.js | 2 +- test/mjsunit/const-redecl.js | 4 +- test/mjsunit/date-parse.js | 2 +- test/mjsunit/debug-compile-event.js | 2 +- test/mjsunit/debug-evaluate-recursive.js | 2 +- test/mjsunit/debug-handle.js | 4 +- test/mjsunit/debug-listbreakpoints.js | 2 +- test/mjsunit/debug-references.js | 4 +- test/mjsunit/debug-return-value.js | 8 ++-- test/mjsunit/debug-stepin-call-function-stub.js | 4 +- test/mjsunit/debug-stepin-constructor.js | 2 +- test/mjsunit/delete-in-with.js | 2 +- test/mjsunit/function-source.js | 2 +- test/mjsunit/get-own-property-descriptor.js | 2 +- test/mjsunit/global-deleted-property-keyed.js | 2 +- test/mjsunit/html-string-funcs.js | 2 +- test/mjsunit/in.js | 2 +- test/mjsunit/instanceof.js | 6 +-- test/mjsunit/keyed-storage-extend.js | 2 +- test/mjsunit/mirror-array.js | 4 +- test/mjsunit/mirror-function.js | 2 +- test/mjsunit/mirror-script.js | 2 +- test/mjsunit/mirror-unresolved-function.js | 2 +- test/mjsunit/no-semicolon.js | 4 +- test/mjsunit/object-define-properties.js | 2 +- test/mjsunit/object-literal-conversions.js | 2 +- test/mjsunit/object-literal-overwrite.js | 4 +- test/mjsunit/object-prevent-extensions.js | 2 +- test/mjsunit/regress/regress-1081309.js | 2 +- test/mjsunit/regress/regress-1092.js | 2 +- test/mjsunit/regress/regress-1110.js | 2 +- test/mjsunit/regress/regress-1213575.js | 2 +- test/mjsunit/regress/regress-1919169.js | 2 +- test/mjsunit/regress/regress-20070207.js | 2 +- test/mjsunit/regress/regress-269.js | 4 +- test/mjsunit/regress/regress-619.js | 2 +- test/mjsunit/regress/regress-678525.js | 8 ++-- test/mjsunit/regress/regress-696.js | 2 +- test/mjsunit/regress/regress-720.js | 2 +- test/mjsunit/regress/regress-747.js | 4 +- test/mjsunit/regress/regress-760-1.js | 2 +- test/mjsunit/regress/regress-760-2.js | 2 +- test/mjsunit/regress/regress-798.js | 14 +++---- test/mjsunit/regress/regress-918.js | 2 +- test/mjsunit/regress/regress-925537.js | 4 +- test/mjsunit/regress/regress-937896.js | 2 +- test/mjsunit/setter-on-constructor-prototype.js | 26 ++++++------- test/mjsunit/string-compare-alignment.js | 5 ++- test/mjsunit/string-indexof-1.js | 4 +- test/mjsunit/string-indexof-2.js | 6 +-- test/mjsunit/string-slices.js | 4 +- test/mjsunit/string-split.js | 4 +- test/mjsunit/substr.js | 2 +- test/mjsunit/this-property-assignment.js | 2 +- test/mjsunit/try.js | 4 +- test/mjsunit/unicode-test.js | 4 +- test/mjsunit/value-wrapper.js | 14 +++---- test/mozilla/mozilla.status | 4 +- tools/gdb-v8-support.py | 2 +- tools/presubmit.py | 24 ++++++++++-- tools/process-heap-prof.py | 6 +-- 74 files changed, 187 insertions(+), 170 deletions(-) diff --git a/benchmarks/crypto.js b/benchmarks/crypto.js index ffa69b5..531ad45 100644 --- a/benchmarks/crypto.js +++ b/benchmarks/crypto.js @@ -1406,7 +1406,7 @@ function rng_seed_int(x) { // Mix in the current time (w/milliseconds) into the pool function rng_seed_time() { - // Use pre-computed date to avoid making the benchmark + // Use pre-computed date to avoid making the benchmark // results dependent on the current date. rng_seed_int(1122926989487); } diff --git a/benchmarks/earley-boyer.js b/benchmarks/earley-boyer.js index 1be480e..b2328d6 100644 --- a/benchmarks/earley-boyer.js +++ b/benchmarks/earley-boyer.js @@ -134,7 +134,7 @@ function sc_rempropBang(sym, key) { /*** META ((export #t)) */ function sc_any2String(o) { return jsstring2string(sc_toDisplayString(o)); -} +} /*** META ((export #t) (peephole (infix 2 2 "===")) @@ -923,7 +923,7 @@ function sc_dualAppendBang(l1, l2) { tmp.cdr = l2; return l1; } - + /*** META ((export #t)) */ function sc_appendBang() { var res = null; @@ -1163,7 +1163,7 @@ sc_Char.readable2char = { "us": "\037", "sp": "\040", "del": "\177"}; - + sc_Char.prototype.toString = function() { return this.val; }; @@ -1533,7 +1533,7 @@ function sc_mapBang(proc, l1) { } return l1_orig; } - + /*** META ((export #t)) */ function sc_forEach(proc, l1) { if (l1 === undefined) @@ -1871,7 +1871,7 @@ function sc_jsNew(c) { evalStr += ", arguments[" + i + "]"; evalStr +=")"; return eval(evalStr); -} +} // ======================== RegExp ==================== /*** META ((export #t)) */ @@ -1883,9 +1883,9 @@ function sc_pregexp(re) { function sc_pregexpMatch(re, s) { var reg = (re instanceof RegExp) ? re : sc_pregexp(re); var tmp = reg.exec(sc_string2jsstring(s)); - + if (tmp == null) return false; - + var res = null; for (var i = tmp.length-1; i >= 0; i--) { if (tmp[i] !== null) { @@ -1896,7 +1896,7 @@ function sc_pregexpMatch(re, s) { } return res; } - + /*** META ((export #t)) */ function sc_pregexpReplace(re, s1, s2) { var reg; @@ -1914,7 +1914,7 @@ function sc_pregexpReplace(re, s1, s2) { return jss1.replace(reg, jss2); } - + /*** META ((export pregexp-replace*)) */ function sc_pregexpReplaceAll(re, s1, s2) { var reg; @@ -1945,7 +1945,7 @@ function sc_pregexpSplit(re, s) { return sc_vector2list(tmp); } - + /* =========================================================================== */ /* Other library stuff */ @@ -2136,7 +2136,7 @@ sc_ErrorInputPort.prototype.getNextChar = function() { sc_ErrorInputPort.prototype.isCharReady = function() { return false; }; - + /* .............. String port ..........................*/ @@ -2200,7 +2200,7 @@ sc_Tokenizer.prototype.readToken = function() { }; sc_Tokenizer.prototype.nextToken = function() { var port = this.port; - + function isNumberChar(c) { return (c >= "0" && c <= "9"); }; @@ -2280,7 +2280,7 @@ sc_Tokenizer.prototype.nextToken = function() { else return new sc_Token(12/*NUMBER*/, res - 0); }; - + function skipWhitespaceAndComments() { var done = false; while (!done) { @@ -2299,7 +2299,7 @@ sc_Tokenizer.prototype.nextToken = function() { } } }; - + function readDot() { if (isWhitespace(port.peekChar())) return new sc_Token(10/*DOT*/); @@ -2429,7 +2429,7 @@ sc_Reader.prototype.read = function() { while (true) { var token = tokenizer.peekToken(); - + switch (token.type) { case 2/*CLOSE_PAR*/: case 4/*CLOSE_BRACE*/: @@ -2491,7 +2491,7 @@ sc_Reader.prototype.read = function() { else throw "bad reference: " + nb; }; - + var tokenizer = this.tokenizer; var token = tokenizer.readToken(); @@ -2499,7 +2499,7 @@ sc_Reader.prototype.read = function() { // handle error if (token.type === 13/*ERROR*/) throw token.val; - + switch (token.type) { case 1/*OPEN_PAR*/: case 3/*OPEN_BRACE*/: @@ -2550,7 +2550,7 @@ function sc_peekChar(port) { port = SC_DEFAULT_IN; // THREAD: shared var... var t = port.peekChar(); return t === SC_EOF_OBJECT? t: new sc_Char(t); -} +} /*** META ((export #t) (type bool)) */ @@ -2722,7 +2722,7 @@ sc_StringOutputPort.prototype.close = function() { function sc_getOutputString(sp) { return sc_jsstring2string(sp.res); } - + function sc_ErrorOutputPort() { } @@ -2852,7 +2852,7 @@ function sc_newline(p) { p = SC_DEFAULT_OUT; p.appendJSString("\n"); } - + /* ------------------ write-char ---------------------------------------------------*/ /*** META ((export #t)) */ @@ -2927,7 +2927,7 @@ sc_Pair.prototype.sc_toWriteCircleString = function(symb, inList) { } var res = ""; - + if (this[symb] !== undefined) { // implies > 0 this[symb + "use"] = true; if (inList) @@ -2939,10 +2939,10 @@ sc_Pair.prototype.sc_toWriteCircleString = function(symb, inList) { if (!inList) res += "("; - + // print car res += sc_genToWriteCircleString(this.car, symb); - + if (sc_isPair(this.cdr)) { res += " " + this.cdr.sc_toWriteCircleString(symb, true); } else if (this.cdr !== null) { @@ -3072,7 +3072,7 @@ function sc_format(s, args) { p.appendJSString(arguments[j].toString(2)); i += 2; j++; break; - + case 37: case 110: // %, n @@ -3186,7 +3186,7 @@ function sc_isEqual(o1, o2) { function sc_number2symbol(x, radix) { return sc_SYMBOL_PREFIX + sc_number2jsstring(x, radix); } - + /*** META ((export number->string integer->string)) */ var sc_number2string = sc_number2jsstring; diff --git a/benchmarks/regexp.js b/benchmarks/regexp.js index 71b9e63..9c83142 100644 --- a/benchmarks/regexp.js +++ b/benchmarks/regexp.js @@ -33,7 +33,7 @@ // the popularity of the pages where it occurs and the number of times // it is executed while loading each page. Furthermore the literal // letters in the data are encoded using ROT13 in a way that does not -// affect how the regexps match their input. Finally the strings are +// affect how the regexps match their input. Finally the strings are // scrambled to exercise the regexp engine on different input strings. @@ -47,7 +47,7 @@ function RegExpSetup() { regExpBenchmark = new RegExpBenchmark(); RegExpRun(); // run once to get system initialized } - + function RegExpRun() { regExpBenchmark.run(); } @@ -1759,6 +1759,6 @@ function RegExpBenchmark() { runBlock11(); } } - + this.run = run; } diff --git a/build/all.gyp b/build/all.gyp index b87b1c0..4b2fe52 100644 --- a/build/all.gyp +++ b/build/all.gyp @@ -1,4 +1,4 @@ -# Copyright (c) 2011 The Chromium Authors. All rights reserved. +# Copyright 2011 the V8 project authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. diff --git a/include/v8.h b/include/v8.h index 5a78160..80193c4 100644 --- a/include/v8.h +++ b/include/v8.h @@ -1656,7 +1656,7 @@ class Object : public Value { V8EXPORT bool IsCallable(); /** - * Call an Object as a function if a callback is set by the + * Call an Object as a function if a callback is set by the * ObjectTemplate::SetCallAsFunctionHandler method. */ V8EXPORT Local CallAsFunction(Handle recv, @@ -3562,7 +3562,7 @@ class V8EXPORT Context { * // V8 Now no longer locked. * \endcode * - * + * */ class V8EXPORT Unlocker { public: diff --git a/src/d8.js b/src/d8.js index a2b9585..3009037 100644 --- a/src/d8.js +++ b/src/d8.js @@ -1786,7 +1786,7 @@ function decodeLolInfoResponse(body) { function decodeLolListResponse(body, title) { - + var result; var total_count = body.count; var total_size = body.size; diff --git a/src/macros.py b/src/macros.py index 5ba7ac3..dc1ccdd 100644 --- a/src/macros.py +++ b/src/macros.py @@ -170,7 +170,7 @@ macro CAPTURE(index) = (3 + (index)); const CAPTURE0 = 3; const CAPTURE1 = 4; -# PropertyDescriptor return value indices - must match +# PropertyDescriptor return value indices - must match # PropertyDescriptorIndices in runtime.cc. const IS_ACCESSOR_INDEX = 0; const VALUE_INDEX = 1; diff --git a/test/es5conform/es5conform.status b/test/es5conform/es5conform.status index 55712ba..d095a24 100644 --- a/test/es5conform/es5conform.status +++ b/test/es5conform/es5conform.status @@ -75,11 +75,11 @@ chapter15/15.2/15.2.3/15.2.3.3/15.2.3.3-4-214: UNIMPLEMENTED # NOT IMPLEMENTED: RegExp.prototype.multiline chapter15/15.2/15.2.3/15.2.3.3/15.2.3.3-4-215: UNIMPLEMENTED -# All of the tests below marked SUBSETFAIL (in 15.2.3.4) fail because +# All of the tests below marked SUBSETFAIL (in 15.2.3.4) fail because # the tests assumes that objects can not have more properties -# than those described in the spec - but according to spec they can +# than those described in the spec - but according to spec they can # have additional properties. -# All compareArray calls in these tests could be exchanged with a +# All compareArray calls in these tests could be exchanged with a # isSubsetOfArray call (I will upload a patch to the es5conform site). # SUBSETFAIL diff --git a/test/mjsunit/array-constructor.js b/test/mjsunit/array-constructor.js index 063ccde..bf5d3d6 100644 --- a/test/mjsunit/array-constructor.js +++ b/test/mjsunit/array-constructor.js @@ -73,7 +73,7 @@ for (var i = 0; i < loop_count; i++) { a = new Array(0, 1, 2, 3, 4, 5, 6, 7, 8); assertArrayEquals([0, 1, 2, 3, 4, 5, 6, 7, 8], a); a = new Array(0, 1, 2, 3, 4, 5, 6, 7, 8, 9); - assertArrayEquals([0, 1, 2, 3, 4, 5, 6, 7, 8, 9], a); + assertArrayEquals([0, 1, 2, 3, 4, 5, 6, 7, 8, 9], a); } @@ -91,9 +91,9 @@ function testConstructOfSizeSize(n) { var a = eval('[' + str + ']'); var b = eval('new Array(' + str + ')') var c = eval('Array(' + str + ')') - assertEquals(n, a.length); - assertArrayEquals(a, b); - assertArrayEquals(a, c); + assertEquals(n, a.length); + assertArrayEquals(a, b); + assertArrayEquals(a, c); } diff --git a/test/mjsunit/array-iteration.js b/test/mjsunit/array-iteration.js index f11b51c..0ee2e6e 100644 --- a/test/mjsunit/array-iteration.js +++ b/test/mjsunit/array-iteration.js @@ -134,7 +134,7 @@ a = [0,1]; assertFalse(a.every(function(n, index, array) { array[index] = n + 1; return n == 1;})); assertArrayEquals([1,1], a); - + // Only loop through initial part of array eventhough elements are // added. a = [1,1]; @@ -156,23 +156,23 @@ // (function() { var a = [0,1,2,3,4]; - + // Simple use. var result = [1,2,3,4,5]; assertArrayEquals(result, a.map(function(n) { return n + 1; })); assertEquals(a, a); - + // Use specified object as this object when calling the function. var o = { delta: 42 } result = [42,43,44,45,46]; assertArrayEquals(result, a.map(function(n) { return this.delta + n; }, o)); - + // Modify original array. a = [0,1,2,3,4]; result = [1,2,3,4,5]; assertArrayEquals(result, a.map(function(n, index, array) { array[index] = n + 1; return n + 1;})); assertArrayEquals(result, a); - + // Only loop through initial part of array eventhough elements are // added. a = [0,1,2,3,4]; @@ -197,7 +197,7 @@ // Simple use. assertTrue(a.some(function(n) { return n == 3})); assertFalse(a.some(function(n) { return n == 5})); - + // Use specified object as this object when calling the function. var o = { element: 42 }; a = [1,42,3]; diff --git a/test/mjsunit/array-sort.js b/test/mjsunit/array-sort.js index fd18a5b..3fa623a 100644 --- a/test/mjsunit/array-sort.js +++ b/test/mjsunit/array-sort.js @@ -392,7 +392,7 @@ TestSpecialCasesInheritedElementSort(); // Test that sort calls compare function with global object as receiver, // and with only elements of the array as arguments. -function o(v) { +function o(v) { return {__proto__: o.prototype, val: v}; } var arr = [o(1), o(2), o(4), o(8), o(16), o(32), o(64), o(128), o(256), o(-0)]; diff --git a/test/mjsunit/bugs/618.js b/test/mjsunit/bugs/618.js index afa9929..ddc0c19 100644 --- a/test/mjsunit/bugs/618.js +++ b/test/mjsunit/bugs/618.js @@ -32,14 +32,14 @@ function C1() { var c1 = new C1(); assertEquals(23, c1.x); assertEquals("undefined", typeof c1.y); - + // Add setter somewhere on the prototype chain after having constructed the // first instance. C1.prototype = { set x(value) { this.y = 23; } }; var c1 = new C1(); assertEquals("undefined", typeof c1.x); assertEquals(23, c1.y); - + // Simple class using inline constructor. function C2() { this.x = 23; diff --git a/test/mjsunit/bugs/bug-618.js b/test/mjsunit/bugs/bug-618.js index 8f47440..ae84326 100644 --- a/test/mjsunit/bugs/bug-618.js +++ b/test/mjsunit/bugs/bug-618.js @@ -33,11 +33,11 @@ function C() { this.x = 23; } -// If a setter is added to the prototype chain of a simple constructor setting -// one of the properties assigned in the constructor then this setter is +// If a setter is added to the prototype chain of a simple constructor setting +// one of the properties assigned in the constructor then this setter is // ignored when constructing new objects from the constructor. -// This only happens if the setter is added _after_ an instance has been +// This only happens if the setter is added _after_ an instance has been // created. assertEquals(23, new C().x); diff --git a/test/mjsunit/compiler/global-accessors.js b/test/mjsunit/compiler/global-accessors.js index bd031a8..337424d 100644 --- a/test/mjsunit/compiler/global-accessors.js +++ b/test/mjsunit/compiler/global-accessors.js @@ -26,7 +26,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // This test tests that no bailouts are missing by not hitting asserts in debug -// mode. +// mode. test_count_operation() test_compound_assignment() diff --git a/test/mjsunit/const-redecl.js b/test/mjsunit/const-redecl.js index 26d765b..9459708 100644 --- a/test/mjsunit/const-redecl.js +++ b/test/mjsunit/const-redecl.js @@ -55,7 +55,7 @@ function TestLocal(s,e) { function TestGlobal(s,e) { // Collect the global properties before the call. var properties = []; - for (var key in this) properties.push(key); + for (var key in this) properties.push(key); // Compute the result. var result; try { @@ -113,7 +113,7 @@ function TestConflict(def0, def1) { // Eval second definition. TestAll("TypeError", def0 + '; eval("' + def1 + '")'); // Eval both definitions separately. - TestAll("TypeError", 'eval("' + def0 +'"); eval("' + def1 + '")'); + TestAll("TypeError", 'eval("' + def0 +'"); eval("' + def1 + '")'); } diff --git a/test/mjsunit/date-parse.js b/test/mjsunit/date-parse.js index a1eef66..b46e39a 100644 --- a/test/mjsunit/date-parse.js +++ b/test/mjsunit/date-parse.js @@ -286,7 +286,7 @@ for (var i = 0; i < 24 * 365 * 100; i += 150) { // Negative tests. var testCasesNegative = [ 'May 25 2008 1:30 (PM)) UTC', // Bad unmatched ')' after number. - 'May 25 2008 1:30( )AM (PM)', // + 'May 25 2008 1:30( )AM (PM)', // 'May 25 2008 AAA (GMT)']; // Unknown word after number. testCasesNegative.forEach(function (s) { diff --git a/test/mjsunit/debug-compile-event.js b/test/mjsunit/debug-compile-event.js index b00a907..94dddfa 100644 --- a/test/mjsunit/debug-compile-event.js +++ b/test/mjsunit/debug-compile-event.js @@ -81,7 +81,7 @@ function listener(event, exec_state, event_data, data) { assertTrue('context' in msg.body.script); // Check that we pick script name from //@ sourceURL, iff present - assertEquals(current_source.indexOf('sourceURL') >= 0 ? + assertEquals(current_source.indexOf('sourceURL') >= 0 ? 'myscript.js' : undefined, event_data.script().name()); } diff --git a/test/mjsunit/debug-evaluate-recursive.js b/test/mjsunit/debug-evaluate-recursive.js index 6ee391b..f34943e 100644 --- a/test/mjsunit/debug-evaluate-recursive.js +++ b/test/mjsunit/debug-evaluate-recursive.js @@ -110,7 +110,7 @@ function listener_recurse(event, exec_state, event_data, data) { if (event == Debug.DebugEvent.Break) { break_count++; - + // Call functions with break using the FrameMirror directly. if (break_count == 1) { // First break event evaluates with break enabled. diff --git a/test/mjsunit/debug-handle.js b/test/mjsunit/debug-handle.js index 98875ce..1582b9f 100644 --- a/test/mjsunit/debug-handle.js +++ b/test/mjsunit/debug-handle.js @@ -72,7 +72,7 @@ function lookupRequest(exec_state, arguments, success) { // The base part of all lookup requests. var base_request = '"seq":0,"type":"request","command":"lookup"' - + // Generate request with the supplied arguments. var request; if (arguments) { @@ -214,7 +214,7 @@ function listener(event, exec_state, event_data, data) { 'Handle not in the request: ' + handle); count++; } - assertEquals(count, obj.properties.length, + assertEquals(count, obj.properties.length, 'Unexpected number of resolved objects'); diff --git a/test/mjsunit/debug-listbreakpoints.js b/test/mjsunit/debug-listbreakpoints.js index de0114f..1d4755f 100644 --- a/test/mjsunit/debug-listbreakpoints.js +++ b/test/mjsunit/debug-listbreakpoints.js @@ -39,7 +39,7 @@ Debug = debug.Debug // below. The test checks for these line numbers. function g() { // line 40 - var x = 5; + var x = 5; var y = 6; var z = 7; }; diff --git a/test/mjsunit/debug-references.js b/test/mjsunit/debug-references.js index ab6c629..763e354 100644 --- a/test/mjsunit/debug-references.js +++ b/test/mjsunit/debug-references.js @@ -52,7 +52,7 @@ function testRequest(dcp, arguments, success, count) { } else { request = '{' + base_request + '}' } - + // Process the request and check expectation. var response = safeEval(dcp.processDebugJSONRequest(request)); if (success) { @@ -88,7 +88,7 @@ function listener(event, exec_state, event_data, data) { var response = safeEval(dcp.processDebugJSONRequest(evaluate_point)); assertTrue(response.success, "Evaluation of Point failed"); var handle = response.body.handle; - + // Test some legal references requests. testRequest(dcp, '{"handle":' + handle + ',"type":"referencedBy"}', true); testRequest(dcp, '{"handle":' + handle + ',"type":"constructedBy"}', diff --git a/test/mjsunit/debug-return-value.js b/test/mjsunit/debug-return-value.js index 3982ea9..02d6a7c 100644 --- a/test/mjsunit/debug-return-value.js +++ b/test/mjsunit/debug-return-value.js @@ -103,12 +103,12 @@ function listener(event, exec_state, event_data, data) { // Position at the end of the function. assertEquals(debugger_source_position + 50, exec_state.frame(0).sourcePosition()); - + // Just about to return from the function. assertTrue(exec_state.frame(0).isAtReturn()) assertEquals(expected_return_value, exec_state.frame(0).returnValue().value()); - + // Check the same using the JSON commands. var dcp = exec_state.debugCommandProcessor(false); var request = '{"seq":0,"type":"request","command":"backtrace"}'; @@ -118,7 +118,7 @@ function listener(event, exec_state, event_data, data) { assertTrue(frames[0].atReturn); assertEquals(expected_return_value, response.lookup(frames[0].returnValue.ref).value); - + listener_complete = true; } } @@ -132,7 +132,7 @@ Debug.setListener(listener); // Four steps from the debugger statement in this function will position us at // the function return. -// 0 1 2 3 4 5 +// 0 1 2 3 4 5 // 0123456789012345678901234567890123456789012345678901 function f(x) {debugger; if (x) { return 1; } else { return 2; } }; diff --git a/test/mjsunit/debug-stepin-call-function-stub.js b/test/mjsunit/debug-stepin-call-function-stub.js index c5cf8fd..053b8bf 100644 --- a/test/mjsunit/debug-stepin-call-function-stub.js +++ b/test/mjsunit/debug-stepin-call-function-stub.js @@ -62,7 +62,7 @@ function listener(event, exec_state, event_data, data) { Debug.setListener(listener); -function g() { +function g() { return "s"; // expected line } @@ -71,7 +71,7 @@ function testFunction() { var s = 1 +f(10); } -function g2() { +function g2() { return "s2"; // expected line } diff --git a/test/mjsunit/debug-stepin-constructor.js b/test/mjsunit/debug-stepin-constructor.js index 6ee3347..5549814 100644 --- a/test/mjsunit/debug-stepin-constructor.js +++ b/test/mjsunit/debug-stepin-constructor.js @@ -38,7 +38,7 @@ function listener(event, exec_state, event_data, data) { if (exec_state.frameCount() > 1) { exec_state.prepareStep(Debug.StepAction.StepIn); } - + // Test that there is a script. assertTrue(typeof(event_data.func().script()) == 'object'); } diff --git a/test/mjsunit/delete-in-with.js b/test/mjsunit/delete-in-with.js index 1efc18d..cbcfe99 100644 --- a/test/mjsunit/delete-in-with.js +++ b/test/mjsunit/delete-in-with.js @@ -29,6 +29,6 @@ // objects from within 'with' statements. (function(){ var tmp = { x: 12 }; - with (tmp) { assertTrue(delete x); } + with (tmp) { assertTrue(delete x); } assertFalse("x" in tmp); })(); diff --git a/test/mjsunit/function-source.js b/test/mjsunit/function-source.js index 7525775..8f2fc22 100644 --- a/test/mjsunit/function-source.js +++ b/test/mjsunit/function-source.js @@ -36,7 +36,7 @@ function f() { } h(); } - + function g() { function h() { assertEquals(Debug.scriptSource(f), Debug.scriptSource(h)); diff --git a/test/mjsunit/get-own-property-descriptor.js b/test/mjsunit/get-own-property-descriptor.js index 79c1fac..abb2420 100644 --- a/test/mjsunit/get-own-property-descriptor.js +++ b/test/mjsunit/get-own-property-descriptor.js @@ -27,7 +27,7 @@ // This file only tests very simple descriptors that always have // configurable, enumerable, and writable set to true. -// A range of more elaborate tests are performed in +// A range of more elaborate tests are performed in // object-define-property.js function get() { return x; } diff --git a/test/mjsunit/global-deleted-property-keyed.js b/test/mjsunit/global-deleted-property-keyed.js index 1a1d3cb..dba3a4d 100644 --- a/test/mjsunit/global-deleted-property-keyed.js +++ b/test/mjsunit/global-deleted-property-keyed.js @@ -33,6 +33,6 @@ var name = "fisk"; natives[name] = name; function foo() { natives[name] + 12; } -for(var i = 0; i < 3; i++) foo(); +for(var i = 0; i < 3; i++) foo(); delete natives[name]; for(var i = 0; i < 3; i++) foo(); diff --git a/test/mjsunit/html-string-funcs.js b/test/mjsunit/html-string-funcs.js index 213b7f3..b640639 100644 --- a/test/mjsunit/html-string-funcs.js +++ b/test/mjsunit/html-string-funcs.js @@ -29,7 +29,7 @@ // HTML. function CheckSimple(f, tag) { assertEquals('<' + tag + '>foo', - "foo"[f]().toLowerCase()); + "foo"[f]().toLowerCase()); }; var simple = { big: 'big', blink: 'blink', bold: 'b', fixed: 'tt', italics: 'i', small: 'small', diff --git a/test/mjsunit/in.js b/test/mjsunit/in.js index f98db42..cca6187 100644 --- a/test/mjsunit/in.js +++ b/test/mjsunit/in.js @@ -86,7 +86,7 @@ a[1] = 2; assertFalse(0 in a); assertTrue(1 in a); assertFalse(2 in a); -assertFalse('0' in a); +assertFalse('0' in a); assertTrue('1' in a); assertFalse('2' in a); assertTrue('toString' in a, "toString"); diff --git a/test/mjsunit/instanceof.js b/test/mjsunit/instanceof.js index 01ea426..050ef2d 100644 --- a/test/mjsunit/instanceof.js +++ b/test/mjsunit/instanceof.js @@ -60,10 +60,10 @@ TestChains(); function TestExceptions() { function F() { } - var items = [ 1, new Number(42), - true, + var items = [ 1, new Number(42), + true, 'string', new String('hest'), - {}, [], + {}, [], F, new F(), Object, String ]; diff --git a/test/mjsunit/keyed-storage-extend.js b/test/mjsunit/keyed-storage-extend.js index 04d2f04..d7e157b 100644 --- a/test/mjsunit/keyed-storage-extend.js +++ b/test/mjsunit/keyed-storage-extend.js @@ -37,7 +37,7 @@ function GrowNamed(o) { } function GrowKeyed(o) { - var names = ['a','b','c','d','e','f']; + var names = ['a','b','c','d','e','f']; var i = 0; o[names[i++]] = i; o[names[i++]] = i; diff --git a/test/mjsunit/mirror-array.js b/test/mjsunit/mirror-array.js index eb8f72a..92e3913 100644 --- a/test/mjsunit/mirror-array.js +++ b/test/mjsunit/mirror-array.js @@ -64,7 +64,7 @@ function testArrayMirror(a, names) { assertTrue(mirror.protoObject() instanceof debug.Mirror, 'Unexpected mirror hierachy'); assertTrue(mirror.prototypeObject() instanceof debug.Mirror, 'Unexpected mirror hierachy'); assertEquals(mirror.length(), a.length, "Length mismatch"); - + var indexedProperties = mirror.indexedPropertiesFromRange(); assertEquals(indexedProperties.length, a.length); for (var i = 0; i < indexedProperties.length; i++) { @@ -110,7 +110,7 @@ function testArrayMirror(a, names) { var found = false; for (var j = 0; j < fromJSON.properties.length; j++) { if (names[i] == fromJSON.properties[j].name) { - found = true; + found = true; } } assertTrue(found, names[i]) diff --git a/test/mjsunit/mirror-function.js b/test/mjsunit/mirror-function.js index 58aee3d..cda815d 100644 --- a/test/mjsunit/mirror-function.js +++ b/test/mjsunit/mirror-function.js @@ -65,7 +65,7 @@ function testFunctionMirror(f) { assertTrue(mirror.constructorFunction() instanceof debug.ObjectMirror); assertTrue(mirror.protoObject() instanceof debug.Mirror); assertTrue(mirror.prototypeObject() instanceof debug.Mirror); - + // Test text representation assertEquals(f.toString(), mirror.toText()); diff --git a/test/mjsunit/mirror-script.js b/test/mjsunit/mirror-script.js index 7156170..1d64ac2 100644 --- a/test/mjsunit/mirror-script.js +++ b/test/mjsunit/mirror-script.js @@ -62,7 +62,7 @@ function testScriptMirror(f, file_name, file_lines, type, compilation_type, if (eval_from_line) { assertEquals(eval_from_line, mirror.evalFromLocation().line); } - + // Parse JSON representation and check. var fromJSON = JSON.parse(json); assertEquals('script', fromJSON.type); diff --git a/test/mjsunit/mirror-unresolved-function.js b/test/mjsunit/mirror-unresolved-function.js index c1fe4a3..46f22a0 100644 --- a/test/mjsunit/mirror-unresolved-function.js +++ b/test/mjsunit/mirror-unresolved-function.js @@ -64,7 +64,7 @@ assertEquals(void 0, mirror.source()); assertEquals('undefined', mirror.constructorFunction().type()); assertEquals('undefined', mirror.protoObject().type()); assertEquals('undefined', mirror.prototypeObject().type()); - + // Parse JSON representation of unresolved functions and check. var fromJSON = eval('(' + json + ')'); assertEquals('function', fromJSON.type, 'Unexpected mirror type in JSON'); diff --git a/test/mjsunit/no-semicolon.js b/test/mjsunit/no-semicolon.js index fa6ccba..273ec4b 100644 --- a/test/mjsunit/no-semicolon.js +++ b/test/mjsunit/no-semicolon.js @@ -30,7 +30,7 @@ function f() { return } -function g() { +function g() { return 4; } @@ -42,4 +42,4 @@ for (var i = 0; i < 10; i++) { break } assertEquals(0, i); for (var i = 0; i < 10; i++) { continue } -assertEquals(10, i); \ No newline at end of file +assertEquals(10, i); diff --git a/test/mjsunit/object-define-properties.js b/test/mjsunit/object-define-properties.js index 6b3725b..128df69 100644 --- a/test/mjsunit/object-define-properties.js +++ b/test/mjsunit/object-define-properties.js @@ -26,7 +26,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // Tests the Object.defineProperties method - ES 15.2.3.7 -// Note that the internal DefineOwnProperty method is tested through +// Note that the internal DefineOwnProperty method is tested through // object-define-property.js, this file only contains tests specific for // Object.defineProperties. Also note that object-create.js contains // a range of indirect tests on this method since Object.create uses diff --git a/test/mjsunit/object-literal-conversions.js b/test/mjsunit/object-literal-conversions.js index 8540d93..742f814 100644 --- a/test/mjsunit/object-literal-conversions.js +++ b/test/mjsunit/object-literal-conversions.js @@ -43,4 +43,4 @@ var test6 = { 17.31: function() {}, "17.31": 7 }; assertEquals(7, test5[13]); assertEquals(7, test6[17.31]); - \ No newline at end of file + diff --git a/test/mjsunit/object-literal-overwrite.js b/test/mjsunit/object-literal-overwrite.js index 5c58a2d..5a3584d 100644 --- a/test/mjsunit/object-literal-overwrite.js +++ b/test/mjsunit/object-literal-overwrite.js @@ -79,7 +79,7 @@ assertEquals(7, foo7[15]); // Test for the classic code generator. function fun(x) { - var inner = { j: function(x) { return x; }, j: 7 }; + var inner = { j: function(x) { return x; }, j: 7 }; return inner.j; } @@ -115,4 +115,4 @@ function fun3() { var y = fun3(); assertEquals(7, y); -assertEquals(3, glob3); \ No newline at end of file +assertEquals(3, glob3); diff --git a/test/mjsunit/object-prevent-extensions.js b/test/mjsunit/object-prevent-extensions.js index dc32342..322a2cb 100644 --- a/test/mjsunit/object-prevent-extensions.js +++ b/test/mjsunit/object-prevent-extensions.js @@ -33,7 +33,7 @@ var obj1 = {}; assertTrue(Object.isExtensible(obj1)); Object.preventExtensions(obj1); -// Make sure the is_extensible flag is set. +// Make sure the is_extensible flag is set. assertFalse(Object.isExtensible(obj1)); obj1.x = 42; assertEquals(undefined, obj1.x); diff --git a/test/mjsunit/regress/regress-1081309.js b/test/mjsunit/regress/regress-1081309.js index 009ede1..5a6c524 100644 --- a/test/mjsunit/regress/regress-1081309.js +++ b/test/mjsunit/regress/regress-1081309.js @@ -67,7 +67,7 @@ function listener(event, exec_state, event_data, data) { // The expected backtrace is // 1: g // 0: [anonymous] - + // Get the debug command processor. var dcp = exec_state.debugCommandProcessor(false); diff --git a/test/mjsunit/regress/regress-1092.js b/test/mjsunit/regress/regress-1092.js index 0b29231..00422cb 100644 --- a/test/mjsunit/regress/regress-1092.js +++ b/test/mjsunit/regress/regress-1092.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Test that CodeGenerator::EmitKeyedPropertyAssignment for the start +// Test that CodeGenerator::EmitKeyedPropertyAssignment for the start // of an initialization block doesn't normalize the properties of the // JSGlobalProxy. this.w = 0; diff --git a/test/mjsunit/regress/regress-1110.js b/test/mjsunit/regress/regress-1110.js index 204a87b..43b8d77 100644 --- a/test/mjsunit/regress/regress-1110.js +++ b/test/mjsunit/regress/regress-1110.js @@ -29,7 +29,7 @@ try { function Crash() { continue;if (Crash) { - } } + } } Crash(); assertTrue(false); } catch (e) { diff --git a/test/mjsunit/regress/regress-1213575.js b/test/mjsunit/regress/regress-1213575.js index 0c3dcc2..9d82064 100644 --- a/test/mjsunit/regress/regress-1213575.js +++ b/test/mjsunit/regress/regress-1213575.js @@ -33,7 +33,7 @@ this.__defineSetter__('x', function(value) { assertTrue(false); }); var caught = false; try { - eval('const x'); + eval('const x'); } catch(e) { assertTrue(e instanceof TypeError); caught = true; diff --git a/test/mjsunit/regress/regress-1919169.js b/test/mjsunit/regress/regress-1919169.js index 774f265..a732312 100644 --- a/test/mjsunit/regress/regress-1919169.js +++ b/test/mjsunit/regress/regress-1919169.js @@ -30,7 +30,7 @@ function test() { var s2 = "s2"; for (var i = 0; i < 2; i++) { // Crashes in round i==1 with IllegalAccess in %StringAdd(x,y) - var res = 1 + s2; + var res = 1 + s2; s2 = 2; } } diff --git a/test/mjsunit/regress/regress-20070207.js b/test/mjsunit/regress/regress-20070207.js index e90b2ec..b7f7a5c 100644 --- a/test/mjsunit/regress/regress-20070207.js +++ b/test/mjsunit/regress/regress-20070207.js @@ -26,7 +26,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // The following regression test illustrates a problem in using the -// value of setting a property in the arguments object. +// value of setting a property in the arguments object. function f(s) { arguments.length; diff --git a/test/mjsunit/regress/regress-269.js b/test/mjsunit/regress/regress-269.js index 49b24c0..ce165e0 100644 --- a/test/mjsunit/regress/regress-269.js +++ b/test/mjsunit/regress/regress-269.js @@ -40,10 +40,10 @@ Debug.setListener(listener); function g() { } - + function f() { debugger; g.apply(null, ['']); } -f() \ No newline at end of file +f() diff --git a/test/mjsunit/regress/regress-619.js b/test/mjsunit/regress/regress-619.js index 24bdbc1..4d3e66b 100644 --- a/test/mjsunit/regress/regress-619.js +++ b/test/mjsunit/regress/regress-619.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Tests that Object.defineProperty works correctly on array indices. +// Tests that Object.defineProperty works correctly on array indices. // Please see http://code.google.com/p/v8/issues/detail?id=619 for details. var obj = {}; diff --git a/test/mjsunit/regress/regress-678525.js b/test/mjsunit/regress/regress-678525.js index 5ff9c3d..11eaf74 100644 --- a/test/mjsunit/regress/regress-678525.js +++ b/test/mjsunit/regress/regress-678525.js @@ -36,16 +36,16 @@ assertEquals(7, '\7'.charCodeAt(0)); assertEquals(56, '\8'.charCodeAt(0)); assertEquals('\010', '\10'); -assertEquals('\011', '\11'); +assertEquals('\011', '\11'); assertEquals('\012', '\12'); assertEquals('\013', '\13'); assertEquals('\014', '\14'); assertEquals('\015', '\15'); assertEquals('\016', '\16'); assertEquals('\017', '\17'); - + assertEquals('\020', '\20'); -assertEquals('\021', '\21'); +assertEquals('\021', '\21'); assertEquals('\022', '\22'); assertEquals('\023', '\23'); assertEquals('\024', '\24'); @@ -56,4 +56,4 @@ assertEquals('\027', '\27'); assertEquals(73, '\111'.charCodeAt(0)); assertEquals(105, '\151'.charCodeAt(0)); - + diff --git a/test/mjsunit/regress/regress-696.js b/test/mjsunit/regress/regress-696.js index 21977e1..e443c42 100644 --- a/test/mjsunit/regress/regress-696.js +++ b/test/mjsunit/regress/regress-696.js @@ -28,7 +28,7 @@ // See: http://code.google.com/p/v8/issues/detail?id=696 // Because of the change in dateparser in revision 4557 to support time // only strings in Date.parse we also misleadingly supported strings with non -// leading numbers. +// leading numbers. assertTrue(isNaN(Date.parse('x'))); assertTrue(isNaN(Date.parse('1x'))); diff --git a/test/mjsunit/regress/regress-720.js b/test/mjsunit/regress/regress-720.js index 97e1284..267b32d 100644 --- a/test/mjsunit/regress/regress-720.js +++ b/test/mjsunit/regress/regress-720.js @@ -27,7 +27,7 @@ // This regression test is used to ensure that Object.defineProperty // keeps the existing value of the writable flag if none is given -// in the provided descriptor. +// in the provided descriptor. // See: http://code.google.com/p/v8/issues/detail?id=720 var o = {x: 10}; diff --git a/test/mjsunit/regress/regress-747.js b/test/mjsunit/regress/regress-747.js index 6fcc000..648c366 100644 --- a/test/mjsunit/regress/regress-747.js +++ b/test/mjsunit/regress/regress-747.js @@ -40,7 +40,7 @@ try { callEval(); } catch (e) { assertUnreachable(); -} +} gc(); gc(); @@ -53,4 +53,4 @@ try { callEval(); } catch (e) { assertUnreachable(); -} +} diff --git a/test/mjsunit/regress/regress-760-1.js b/test/mjsunit/regress/regress-760-1.js index 2e0cee5..081c993 100644 --- a/test/mjsunit/regress/regress-760-1.js +++ b/test/mjsunit/regress/regress-760-1.js @@ -26,7 +26,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // Check that when valueOf for a String object is overwritten it is called and -// the result used when that object is added with a string. +// the result used when that object is added with a string. // See: http://code.google.com/p/v8/issues/detail?id=760 diff --git a/test/mjsunit/regress/regress-760-2.js b/test/mjsunit/regress/regress-760-2.js index 1b1cbfe..549ed4e 100644 --- a/test/mjsunit/regress/regress-760-2.js +++ b/test/mjsunit/regress/regress-760-2.js @@ -26,7 +26,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // Check that when valueOf for a String object is overwritten it is called and -// the result used when that object is added with a string. +// the result used when that object is added with a string. // See: http://code.google.com/p/v8/issues/detail?id=760 diff --git a/test/mjsunit/regress/regress-798.js b/test/mjsunit/regress/regress-798.js index ffee5da..182eb4d 100644 --- a/test/mjsunit/regress/regress-798.js +++ b/test/mjsunit/regress/regress-798.js @@ -32,7 +32,7 @@ x.__defineGetter__("a", function() { try { y.x = 40; } catch (e) { - assertEquals(3, e.stack.split('\n').length); + assertEquals(3, e.stack.split('\n').length); } return 40; }); @@ -41,7 +41,7 @@ x.__defineSetter__("a", function(val) { try { y.x = 40; } catch(e) { - assertEquals(3, e.stack.split('\n').length); + assertEquals(3, e.stack.split('\n').length); } }); @@ -50,7 +50,7 @@ function getB() { try { y.x = 30; } catch (e) { - assertEquals(3, e.stack.split('\n').length); + assertEquals(3, e.stack.split('\n').length); } return 30; } @@ -59,7 +59,7 @@ function setB(val) { try { y.x = 30; } catch(e) { - assertEquals(3, e.stack.split('\n').length); + assertEquals(3, e.stack.split('\n').length); } } @@ -72,7 +72,7 @@ var descriptor = { try { y.x = 40; } catch (e) { - assertEquals(3, e.stack.split('\n').length); + assertEquals(3, e.stack.split('\n').length); } return 40; }, @@ -80,7 +80,7 @@ var descriptor = { try { y.x = 40; } catch(e) { - assertEquals(3, e.stack.split('\n').length); + assertEquals(3, e.stack.split('\n').length); } } } @@ -88,7 +88,7 @@ var descriptor = { Object.defineProperty(x, 'c', descriptor) // Check that the stack for an exception in a getter and setter produce the -// expected stack height. +// expected stack height. x.a; x.b; x.c; diff --git a/test/mjsunit/regress/regress-918.js b/test/mjsunit/regress/regress-918.js index 4b6ddba..871e9d9 100644 --- a/test/mjsunit/regress/regress-918.js +++ b/test/mjsunit/regress/regress-918.js @@ -28,6 +28,6 @@ // Parser should not accept parentheses around labels. // See http://code.google.com/p/v8/issues/detail?id=918 -// The label was parsed as an expression and then tested for being a +// The label was parsed as an expression and then tested for being a // single identifier. This threw away the parentheses. assertThrows("(label):42;"); diff --git a/test/mjsunit/regress/regress-925537.js b/test/mjsunit/regress/regress-925537.js index 11582ea..d50c568 100644 --- a/test/mjsunit/regress/regress-925537.js +++ b/test/mjsunit/regress/regress-925537.js @@ -28,8 +28,8 @@ function assertClose(expected, actual) { var delta = 0.00001; if (Math.abs(expected - actual) > delta) { - print('Failure: Expected <' + actual + '> to be close to <' + - expected + '>'); + print('Failure: Expected <' + actual + '> to be close to <' + + expected + '>'); } } diff --git a/test/mjsunit/regress/regress-937896.js b/test/mjsunit/regress/regress-937896.js index e8e5ef2..e7831da 100644 --- a/test/mjsunit/regress/regress-937896.js +++ b/test/mjsunit/regress/regress-937896.js @@ -41,7 +41,7 @@ function f() { } } } catch (e) { - // Empty. + // Empty. } return 42; } diff --git a/test/mjsunit/setter-on-constructor-prototype.js b/test/mjsunit/setter-on-constructor-prototype.js index d5718f9..a74f7da 100644 --- a/test/mjsunit/setter-on-constructor-prototype.js +++ b/test/mjsunit/setter-on-constructor-prototype.js @@ -35,14 +35,14 @@ function RunTest(ensure_fast_case) { if (ensure_fast_case) { %ToFastProperties(C1.prototype); } - + for (var i = 0; i < 10; i++) { var c1 = new C1(); assertEquals("undefined", typeof c1.x); assertEquals(23, c1.y); } - - + + function C2() { this.x = 23; }; @@ -51,14 +51,14 @@ function RunTest(ensure_fast_case) { if (ensure_fast_case) { %ToFastProperties(C2.prototype.__proto__) } - + for (var i = 0; i < 10; i++) { var c2 = new C2(); assertEquals("undefined", typeof c2.x); assertEquals(23, c2.y); } - - + + function C3() { this.x = 23; }; @@ -67,14 +67,14 @@ function RunTest(ensure_fast_case) { if (ensure_fast_case) { %ToFastProperties(C3.prototype); } - + for (var i = 0; i < 10; i++) { var c3 = new C3(); assertEquals("undefined", typeof c3.x); assertEquals(23, c3.y); } - - + + function C4() { this.x = 23; }; @@ -84,14 +84,14 @@ function RunTest(ensure_fast_case) { if (ensure_fast_case) { %ToFastProperties(C4.prototype.__proto__); } - + for (var i = 0; i < 10; i++) { var c4 = new C4(); assertEquals("undefined", typeof c4.x); assertEquals(23, c4.y); } - - + + function D() { this.x = 23; }; @@ -99,7 +99,7 @@ function RunTest(ensure_fast_case) { if (ensure_fast_case) { %ToFastProperties(D.prototype); } - + for (var i = 0; i < 10; i++) { var d = new D(); assertEquals(23, d.x); diff --git a/test/mjsunit/string-compare-alignment.js b/test/mjsunit/string-compare-alignment.js index a291417..0ae8eb7 100644 --- a/test/mjsunit/string-compare-alignment.js +++ b/test/mjsunit/string-compare-alignment.js @@ -29,8 +29,9 @@ // This situation can arise with sliced strings. This tests for an ARM bug // that was fixed in r554. -var base = "Now is the time for all good men to come to the aid of the party. " + - "Now is the time for all good men to come to the aid of the party." +var base = + "Now is the time for all good men to come to the aid of the party. " + + "Now is the time for all good men to come to the aid of the party." var s1 = base.substring(0, 64); var s2 = base.substring(66, 130); diff --git a/test/mjsunit/string-indexof-1.js b/test/mjsunit/string-indexof-1.js index c5ae4b8..db3623f 100644 --- a/test/mjsunit/string-indexof-1.js +++ b/test/mjsunit/string-indexof-1.js @@ -63,7 +63,7 @@ assertEquals(1, twoByteString.indexOf("\u0391"), "Alpha"); assertEquals(2, twoByteString.indexOf("\u03a3"), "First Sigma"); assertEquals(3, twoByteString.indexOf("\u03a3",3), "Second Sigma"); assertEquals(4, twoByteString.indexOf("\u0395"), "Epsilon"); -assertEquals(-1, twoByteString.indexOf("\u0392"), "Not beta"); +assertEquals(-1, twoByteString.indexOf("\u0392"), "Not beta"); // Test multi-char pattern assertEquals(0, twoByteString.indexOf("\u039a\u0391"), "lambda Alpha"); @@ -71,7 +71,7 @@ assertEquals(1, twoByteString.indexOf("\u0391\u03a3"), "Alpha Sigma"); assertEquals(2, twoByteString.indexOf("\u03a3\u03a3"), "Sigma Sigma"); assertEquals(3, twoByteString.indexOf("\u03a3\u0395"), "Sigma Epsilon"); -assertEquals(-1, twoByteString.indexOf("\u0391\u03a3\u0395"), +assertEquals(-1, twoByteString.indexOf("\u0391\u03a3\u0395"), "Not Alpha Sigma Epsilon"); //single char pattern diff --git a/test/mjsunit/string-indexof-2.js b/test/mjsunit/string-indexof-2.js index a7c3f60..48db84d 100644 --- a/test/mjsunit/string-indexof-2.js +++ b/test/mjsunit/string-indexof-2.js @@ -57,10 +57,10 @@ for(var i = 0; i < lipsum.length; i += 3) { var index = -1; do { index = lipsum.indexOf(substring, index + 1); - assertTrue(index != -1, + assertTrue(index != -1, "Lipsum substring " + i + ".." + (i + len-1) + " not found"); - assertEquals(lipsum.substring(index, index + len), substring, - "Wrong lipsum substring found: " + i + ".." + (i + len - 1) + "/" + + assertEquals(lipsum.substring(index, index + len), substring, + "Wrong lipsum substring found: " + i + ".." + (i + len - 1) + "/" + index + ".." + (index + len - 1)); } while (index >= 0 && index < i); assertEquals(i, index, "Lipsum match at " + i + ".." + (i + len - 1)); diff --git a/test/mjsunit/string-slices.js b/test/mjsunit/string-slices.js index f629ca9..8cc1f81 100755 --- a/test/mjsunit/string-slices.js +++ b/test/mjsunit/string-slices.js @@ -57,7 +57,7 @@ assertEquals(s, s.substr(-100)); assertEquals('abc', s.substr(-100, 3)); assertEquals(s1, s.substr(-s.length + 1)); -// assertEquals('', s.substr(0, void 0)); // smjs and rhino +// assertEquals('', s.substr(0, void 0)); // smjs and rhino assertEquals('abcdefghijklmn', s.substr(0, void 0)); // kjs and v8 assertEquals('', s.substr(0, null)); assertEquals(s, s.substr(0, String(s.length))); @@ -196,4 +196,4 @@ var b = a.slice(1,-1); assertEquals(a.slice(1,-1), b); externalizeString(a); assertEquals(a.slice(1,-1), b); -*/ \ No newline at end of file +*/ diff --git a/test/mjsunit/string-split.js b/test/mjsunit/string-split.js index bc50945..d8412f0 100644 --- a/test/mjsunit/string-split.js +++ b/test/mjsunit/string-split.js @@ -68,13 +68,13 @@ assertArrayEquals(["a", "b", "c"], "abc".split(/(?=.)/)); /* "ab".split(/((?=.))/) - * + * * KJS: ,a,,b * SM: a,,b, * IE: a,b * Opera: a,,b * V8: a,,b - * + * * Opera seems to have this right. The others make no sense. */ assertArrayEquals(["a", "", "b"], "ab".split(/((?=.))/)); diff --git a/test/mjsunit/substr.js b/test/mjsunit/substr.js index cffaf94..cab8b1b 100755 --- a/test/mjsunit/substr.js +++ b/test/mjsunit/substr.js @@ -55,7 +55,7 @@ assertEquals(s, s.substr(-100)); assertEquals('abc', s.substr(-100, 3)); assertEquals(s1, s.substr(-s.length + 1)); -// assertEquals('', s.substr(0, void 0)); // smjs and rhino +// assertEquals('', s.substr(0, void 0)); // smjs and rhino assertEquals('abcdefghijklmn', s.substr(0, void 0)); // kjs and v8 assertEquals('', s.substr(0, null)); assertEquals(s, s.substr(0, String(s.length))); diff --git a/test/mjsunit/this-property-assignment.js b/test/mjsunit/this-property-assignment.js index c681999..54c6537 100644 --- a/test/mjsunit/this-property-assignment.js +++ b/test/mjsunit/this-property-assignment.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Tests the handling of multiple assignments to the same property in a +// Tests the handling of multiple assignments to the same property in a // constructor that only has simple this property assignments. function Node() { diff --git a/test/mjsunit/try.js b/test/mjsunit/try.js index 794860a..86afdf7 100644 --- a/test/mjsunit/try.js +++ b/test/mjsunit/try.js @@ -250,7 +250,7 @@ function break_from_nested_catch(x) { } catch (o) { x--; } - } + } return x; } @@ -274,7 +274,7 @@ function break_from_nested_finally(x) { x--; } x--; // should not happen - } + } return x; } diff --git a/test/mjsunit/unicode-test.js b/test/mjsunit/unicode-test.js index 59a684e..66a029a 100644 --- a/test/mjsunit/unicode-test.js +++ b/test/mjsunit/unicode-test.js @@ -807,7 +807,7 @@ var cyrillic = " * Васильев Л.С. Древний Китай: в 3 т. Т. 3. Период Чжаньго (V–III вв. до н.э.). М.: Восточная литература, 2006. ISBN 502018103X\n" + " * Непомнин О.Е. История Китая: Эпоха Цин. XVII – начало XX века. М.: Восточная литература, 2005. ISBN 5020184004\n"; -var devanagari = +var devanagari = "भारत\n" + "विकिपीडिया, एक मुक्त ज्ञानकोष से\n" + "Jump to: navigation, search\n" + @@ -1417,7 +1417,7 @@ var english = "There are many words of French origin in English, such as competition, art, table, publicity, police, role, routine, machine, force, and many others that have been and are being anglicised; they are now pronounced according to English rules of phonology, rather than French. A large portion of English vocabulary is of French or Oïl language origin, most derived from, or transmitted via, the Anglo-Norman spoken by the upper classes in England for several hundred years after the Norman Conquest.\n"; -var greek = +var greek = "Ελλάδα\n" + "Από τη Βικιπαίδεια, την ελεύθερη εγκυκλοπαίδεια\n" + "Ελληνική Δημοκρατία\n" + diff --git a/test/mjsunit/value-wrapper.js b/test/mjsunit/value-wrapper.js index 88330b4..76e200f 100644 --- a/test/mjsunit/value-wrapper.js +++ b/test/mjsunit/value-wrapper.js @@ -39,7 +39,7 @@ function RunTests() { assertEquals('object', (42).TypeOfThis()); assertEquals('object', (3.14).TypeOfThis()); } - + for (var i = 0; i < 10; i++) { assertEquals('object', 'xxx'['TypeOfThis']()); assertEquals('object', true['TypeOfThis']()); @@ -47,11 +47,11 @@ function RunTests() { assertEquals('object', (42)['TypeOfThis']()); assertEquals('object', (3.14)['TypeOfThis']()); } - + function CallTypeOfThis(obj) { assertEquals('object', obj.TypeOfThis()); } - + for (var i = 0; i < 10; i++) { CallTypeOfThis('xxx'); CallTypeOfThis(true); @@ -59,7 +59,7 @@ function RunTests() { CallTypeOfThis(42); CallTypeOfThis(3.14); } - + function TestWithWith(obj) { with (obj) { for (var i = 0; i < 10; i++) { @@ -67,13 +67,13 @@ function RunTests() { } } } - + TestWithWith('xxx'); TestWithWith(true); TestWithWith(false); TestWithWith(42); TestWithWith(3.14); - + for (var i = 0; i < 10; i++) { assertEquals('object', true[7]()); assertEquals('object', false[7]()); @@ -100,7 +100,7 @@ function RunTests() { function TypeOfThis() { return typeof this; } -// Test with normal setup of prototype. +// Test with normal setup of prototype. String.prototype.TypeOfThis = TypeOfThis; Boolean.prototype.TypeOfThis = TypeOfThis; Number.prototype.TypeOfThis = TypeOfThis; diff --git a/test/mozilla/mozilla.status b/test/mozilla/mozilla.status index f6d6925..1a2bb5f 100644 --- a/test/mozilla/mozilla.status +++ b/test/mozilla/mozilla.status @@ -245,7 +245,7 @@ ecma_3/Number/15.7.4.7-1: FAIL_OK # toExponential argument restricted to range 0..20 in JSC/V8 ecma_3/Number/15.7.4.6-1: FAIL_OK -#:=== RegExp:=== +#:=== RegExp:=== # We don't match the syntax error message of Mozilla for invalid # RegExp flags. ecma_3/RegExp/15.10.4.1-6: FAIL_OK @@ -578,7 +578,7 @@ js1_5/Regress/regress-352604: FAIL_OK js1_5/Regress/regress-417893: FAIL_OK -# Unsupported use of "[]" as function parameter. We match JSC. +# Unsupported use of "[]" as function parameter. We match JSC. js1_5/Regress/regress-416737-01: FAIL_OK js1_5/Regress/regress-416737-02: FAIL_OK diff --git a/tools/gdb-v8-support.py b/tools/gdb-v8-support.py index 0aa1d49..9cc046c 100644 --- a/tools/gdb-v8-support.py +++ b/tools/gdb-v8-support.py @@ -138,7 +138,7 @@ def v8_to_int(v): else: return '?' - + def v8_get_value(vstring): v = gdb.parse_and_eval(vstring) return v8_to_int(v) diff --git a/tools/presubmit.py b/tools/presubmit.py index c191fc7..7b4719f 100755 --- a/tools/presubmit.py +++ b/tools/presubmit.py @@ -1,6 +1,6 @@ #!/usr/bin/env python # -# Copyright 2008 the V8 project authors. All rights reserved. +# Copyright 2011 the V8 project authors. All rights reserved. # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions are # met: @@ -88,7 +88,6 @@ whitespace/blank_line whitespace/braces whitespace/comma whitespace/comments -whitespace/end_of_line whitespace/ending_newline whitespace/indent whitespace/labels @@ -231,11 +230,12 @@ COPYRIGHT_HEADER_PATTERN = re.compile( class SourceProcessor(SourceFileProcessor): """ - Check that all files include a copyright notice. + Check that all files include a copyright notice and no trailing whitespaces. """ RELEVANT_EXTENSIONS = ['.js', '.cc', '.h', '.py', '.c', 'SConscript', - 'SConstruct', '.status'] + 'SConstruct', '.status', '.gyp', '.gypi'] + def IsRelevant(self, name): for ext in SourceProcessor.RELEVANT_EXTENSIONS: if name.endswith(ext): @@ -273,6 +273,22 @@ class SourceProcessor(SourceFileProcessor): if not COPYRIGHT_HEADER_PATTERN.search(contents): print "%s is missing a correct copyright header." % name result = False + ext = base.split('.').pop() + if ' \n' in contents or contents.endswith(' '): + line = 0 + lines = [] + parts = contents.split(' \n') + if not contents.endswith(' '): + parts.pop() + for part in parts: + line += part.count('\n') + 1 + lines.append(str(line)) + linenumbers = ', '.join(lines) + if len(lines) > 1: + print "%s has trailing whitespaces in lines %s." % (name, linenumbers) + else: + print "%s has trailing whitespaces in line %s." % (name, linenumbers) + result = False return result def ProcessFiles(self, files, path): diff --git a/tools/process-heap-prof.py b/tools/process-heap-prof.py index 6a2c397..a26cbf1 100755 --- a/tools/process-heap-prof.py +++ b/tools/process-heap-prof.py @@ -47,7 +47,7 @@ def ProcessLogFile(filename, options): itemname = 'heap-js-cons-item' else: itemname = 'heap-sample-item' - + first_call_time = None sample_time = 0.0 sampling = False @@ -108,11 +108,11 @@ def Main(): if not ProcessOptions(options): parser.print_help() sys.exit(); - + if not args: print "Missing logfile" sys.exit(); - + ProcessLogFile(args[0], options) -- 2.7.4