From 867131a96cadb59f69e8f4339c52448e20ce9b8a Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 8 Apr 2019 21:37:08 +0000 Subject: [PATCH] [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping The new value is taken from in the MacOSX10.14 SDK from Xcode 10.1. Update llvm-objdump and llvm-readobj accordingly. Differential Revision: https://reviews.llvm.org/D58636 llvm-svn: 357945 --- llvm/include/llvm/BinaryFormat/MachO.h | 5 ++++- llvm/test/tools/llvm-objdump/AArch64/Inputs/arm64e.macho.yaml | 11 +++++++++++ llvm/test/tools/llvm-objdump/AArch64/macho-arm64e.test | 6 ++++++ llvm/tools/llvm-objdump/MachODump.cpp | 7 +++++++ llvm/tools/llvm-readobj/MachODumper.cpp | 1 + 5 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 llvm/test/tools/llvm-objdump/AArch64/Inputs/arm64e.macho.yaml create mode 100644 llvm/test/tools/llvm-objdump/AArch64/macho-arm64e.test diff --git a/llvm/include/llvm/BinaryFormat/MachO.h b/llvm/include/llvm/BinaryFormat/MachO.h index 08fe780..e0258b1 100644 --- a/llvm/include/llvm/BinaryFormat/MachO.h +++ b/llvm/include/llvm/BinaryFormat/MachO.h @@ -1477,7 +1477,10 @@ enum CPUSubTypeARM { CPU_SUBTYPE_ARM_V7EM = 16 }; -enum CPUSubTypeARM64 { CPU_SUBTYPE_ARM64_ALL = 0 }; +enum CPUSubTypeARM64 { + CPU_SUBTYPE_ARM64_ALL = 0, + CPU_SUBTYPE_ARM64E = 2, +}; enum CPUSubTypeSPARC { CPU_SUBTYPE_SPARC_ALL = 0 }; diff --git a/llvm/test/tools/llvm-objdump/AArch64/Inputs/arm64e.macho.yaml b/llvm/test/tools/llvm-objdump/AArch64/Inputs/arm64e.macho.yaml new file mode 100644 index 0000000..0240355 --- /dev/null +++ b/llvm/test/tools/llvm-objdump/AArch64/Inputs/arm64e.macho.yaml @@ -0,0 +1,11 @@ +--- !mach-o +FileHeader: + magic: 0xFEEDFACF + cputype: 0x0100000C + cpusubtype: 0x00000002 + filetype: 0x00000001 + ncmds: 0 + sizeofcmds: 0 + flags: 0x00000000 + reserved: 0x00000000 +... diff --git a/llvm/test/tools/llvm-objdump/AArch64/macho-arm64e.test b/llvm/test/tools/llvm-objdump/AArch64/macho-arm64e.test new file mode 100644 index 0000000..cd001cf --- /dev/null +++ b/llvm/test/tools/llvm-objdump/AArch64/macho-arm64e.test @@ -0,0 +1,6 @@ +// RUN: yaml2obj %p/Inputs/arm64e.macho.yaml -o %tarm64e.o +// RUN: llvm-objdump -p %tarm64e.o | FileCheck -strict-whitespace %s + +CHECK: Mach header +CHECK-NEXT: magic cputype cpusubtype caps filetype ncmds sizeofcmds flags +CHECK-NEXT: MH_MAGIC_64 ARM64 E 0x00 OBJECT 0 0 0x00000000 diff --git a/llvm/tools/llvm-objdump/MachODump.cpp b/llvm/tools/llvm-objdump/MachODump.cpp index 54c9543..23dc18f 100644 --- a/llvm/tools/llvm-objdump/MachODump.cpp +++ b/llvm/tools/llvm-objdump/MachODump.cpp @@ -2009,6 +2009,10 @@ static void printCPUType(uint32_t cputype, uint32_t cpusubtype) { outs() << " cputype CPU_TYPE_ARM64\n"; outs() << " cpusubtype CPU_SUBTYPE_ARM64_ALL\n"; break; + case MachO::CPU_SUBTYPE_ARM64E: + outs() << " cputype CPU_TYPE_ARM64\n"; + outs() << " cpusubtype CPU_SUBTYPE_ARM64E\n"; + break; default: printUnknownCPUType(cputype, cpusubtype); break; @@ -8084,6 +8088,9 @@ static void PrintMachHeader(uint32_t magic, uint32_t cputype, case MachO::CPU_SUBTYPE_ARM64_ALL: outs() << " ALL"; break; + case MachO::CPU_SUBTYPE_ARM64E: + outs() << " E"; + break; default: outs() << format(" %10d", cpusubtype & ~MachO::CPU_SUBTYPE_MASK); break; diff --git a/llvm/tools/llvm-readobj/MachODumper.cpp b/llvm/tools/llvm-readobj/MachODumper.cpp index 0cb954c..07f9c63 100644 --- a/llvm/tools/llvm-readobj/MachODumper.cpp +++ b/llvm/tools/llvm-readobj/MachODumper.cpp @@ -162,6 +162,7 @@ static const EnumEntry MachOHeaderCpuSubtypesARM[] = { static const EnumEntry MachOHeaderCpuSubtypesARM64[] = { LLVM_READOBJ_ENUM_ENT(MachO, CPU_SUBTYPE_ARM64_ALL), + LLVM_READOBJ_ENUM_ENT(MachO, CPU_SUBTYPE_ARM64E), }; static const EnumEntry MachOHeaderCpuSubtypesSPARC[] = { -- 2.7.4