From 85b309788fbda06aa8d587f3516260e9ad16fcda Mon Sep 17 00:00:00 2001 From: Hyeongseok Oh Date: Mon, 5 Dec 2016 11:32:59 +0900 Subject: [PATCH] Change order in .builds and .pkgproj, fix build.sh for not modifying dir.prop Commit migrated from https://github.com/dotnet/coreclr/commit/d06878377c5addeee92421ed9a287d1790c32cbc --- src/coreclr/build.sh | 35 +++++++++++++--------- src/coreclr/dir.props | 4 +-- .../Microsoft.NETCore.ILAsm.builds | 16 +++++----- .../Microsoft.NETCore.ILAsm.pkgproj | 12 ++++---- .../Microsoft.NETCore.ILDAsm.builds | 16 +++++----- .../Microsoft.NETCore.ILDAsm.pkgproj | 12 ++++---- .../Microsoft.NETCore.Jit.builds | 16 +++++----- .../Microsoft.NETCore.Jit.pkgproj | 12 ++++---- .../Microsoft.NETCore.Runtime.CoreCLR.builds | 16 +++++----- .../Microsoft.NETCore.Runtime.CoreCLR.pkgproj | 12 ++++---- .../Microsoft.NETCore.TestHost.builds | 16 +++++----- .../Microsoft.NETCore.TestHost.pkgproj | 12 ++++---- 12 files changed, 92 insertions(+), 87 deletions(-) diff --git a/src/coreclr/build.sh b/src/coreclr/build.sh index 7dc3f53..a434b23 100755 --- a/src/coreclr/build.sh +++ b/src/coreclr/build.sh @@ -56,29 +56,33 @@ usage() exit 1 } -initDistroRid() +initHostDistroRid() { if [ "$__HostOS" == "Linux" ]; then if [ ! -e /etc/os-release ]; then echo "WARNING: Can not determine runtime id for current distro." - export __DistroRid="" + __HostDistroRid="" else source /etc/os-release - export __DistroRid="$ID.$VERSION_ID-$__HostArch" + __HostDistroRid="$ID.$VERSION_ID-$__HostArch" fi fi } initTargetDistroRid() { - if [ "$__BuildOS" == "Linux" ]; then - if [ ! -e /etc/os-release ]; then - echo "WARNING: Can not determine runtime id for current distro." - export __CrossDistroRid="" - else - source $ROOTFS_DIR/etc/os-release - export __CrossDistroRid="$ID.$VERSION_ID-$__BuildArch" + if [ $__CrossBuild == 1 ]; then + if [ "$__BuildOS" == "Linux" ]; then + if [ ! -e $ROOTFS_DIR/etc/os-release ]; then + echo "WARNING: Can not determine runtime id for current distro." + export __DistroRid="" + else + source $ROOTFS_DIR/etc/os-release + export __DistroRid="$ID.$VERSION_ID-$__BuildArch" + fi fi + else + export __DistroRid="$__HostDistroRid" fi } @@ -241,7 +245,7 @@ isMSBuildOnNETCoreSupported() if [ "$__HostArch" == "x64" ]; then if [ "$__HostOS" == "Linux" ]; then - case "$__DistroRid" in + case "$__HostDistroRid" in "centos.7-x64") __isMSBuildOnNETCoreSupported=1 ;; @@ -489,6 +493,7 @@ __CrossBuild=0 __ClangMajorVersion=0 __ClangMinorVersion=0 __NuGetPath="$__PackagesDir/NuGet.exe" +__HostDistroRid="" __DistroRid="" __cmakeargs="" __SkipGenerateVersion=0 @@ -677,8 +682,8 @@ fi # Set dependent variables __LogsDir="$__RootBinDir/Logs" -# init the distro name -initDistroRid +# init the host distro name +initHostDistroRid # Set the remaining variables based upon the determined build configuration __BinDir="$__RootBinDir/Product/$__BuildOS.$__BuildArch.$__BuildType" @@ -712,9 +717,11 @@ if [ $__CrossBuild == 1 ]; then if ! [[ -n "$ROOTFS_DIR" ]]; then export ROOTFS_DIR="$__ProjectRoot/cross/rootfs/$__BuildArch" fi - initTargetDistroRid fi +# init the target distro name +initTargetDistroRid + # Make the directories necessary for build if they don't exist setup_dirs diff --git a/src/coreclr/dir.props b/src/coreclr/dir.props index 7f6bdb6..615070b 100644 --- a/src/coreclr/dir.props +++ b/src/coreclr/dir.props @@ -128,11 +128,9 @@ true true - true - $(__DistroRid) - $(__CrossDistroRid) + $(__DistroRid) diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.builds b/src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.builds index 692aeb6..90a1786 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.builds +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.builds @@ -55,10 +55,18 @@ Linux amd64 + + Linux + arm + Linux amd64 + + Linux + arm + Linux amd64 @@ -67,14 +75,6 @@ Linux amd64 - - Linux - arm - - - Linux - arm - OSX amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj b/src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj index aa9fcc4..48c8db3 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj @@ -43,21 +43,21 @@ amd64 + + arm + amd64 + + arm + amd64 amd64 - - arm - - - arm - amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.builds b/src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.builds index b856d33..db3bf8b 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.builds +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.builds @@ -55,10 +55,18 @@ Linux amd64 + + Linux + arm + Linux amd64 + + Linux + arm + Linux amd64 @@ -67,14 +75,6 @@ Linux amd64 - - Linux - arm - - - Linux - arm - OSX amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj b/src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj index d26250f..8538749 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj @@ -43,21 +43,21 @@ amd64 + + arm + amd64 + + arm + amd64 amd64 - - arm - - - arm - amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.builds b/src/coreclr/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.builds index 760de04..6a95697 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.builds +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.builds @@ -55,10 +55,18 @@ Linux amd64 + + Linux + arm + Linux amd64 + + Linux + arm + Linux amd64 @@ -67,14 +75,6 @@ Linux amd64 - - Linux - arm - - - Linux - arm - OSX amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.pkgproj b/src/coreclr/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.pkgproj index 7c1510e..6775ccc 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.pkgproj +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.Jit/Microsoft.NETCore.Jit.pkgproj @@ -42,21 +42,21 @@ amd64 + + arm + amd64 + + arm + amd64 amd64 - - arm - - - arm - amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.builds b/src/coreclr/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.builds index 2320d87..6124136 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.builds +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.builds @@ -54,10 +54,18 @@ Linux amd64 + + Linux + arm + Linux amd64 + + Linux + arm + Linux amd64 @@ -66,14 +74,6 @@ Linux amd64 - - Linux - arm - - - Linux - arm - OSX amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.pkgproj b/src/coreclr/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.pkgproj index 7683385..f40ee4f 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.pkgproj +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.Runtime.CoreCLR/Microsoft.NETCore.Runtime.CoreCLR.pkgproj @@ -48,21 +48,21 @@ amd64 + + arm + amd64 + + arm + amd64 amd64 - - arm - - - arm - amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.builds b/src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.builds index 7734bec9..78681ef 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.builds +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.builds @@ -55,10 +55,18 @@ Linux amd64 + + Linux + arm + Linux amd64 + + Linux + arm + Linux amd64 @@ -67,14 +75,6 @@ Linux amd64 - - Linux - arm - - - Linux - arm - OSX amd64 diff --git a/src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.pkgproj b/src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.pkgproj index 5744be8..c831f93 100644 --- a/src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.pkgproj +++ b/src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/Microsoft.NETCore.TestHost.pkgproj @@ -42,21 +42,21 @@ amd64 + + arm + amd64 + + arm + amd64 amd64 - - arm - - - arm - amd64 -- 2.7.4