From 858c9d13240e695bc3b750368f5d4e524b12112e Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 5 Dec 2017 16:39:35 -0500 Subject: [PATCH] Address review comments for the previous series I failed at git and missed adding/lost changes on the wrong branch, the result being that I didn't incorporate fixes resulting from Yao's review comments. This patch fixes that. There are two places where we should use the unique pointer typedef, and ChangeLog entries missing. gdb/ChangeLog: * target-descriptions.c (struct tdesc_feature) : Use tdesc_reg_up typedef. (struct target_desc) : Use tdesc_feature_up typedef. --- gdb/ChangeLog | 8 ++++++++ gdb/target-descriptions.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1d3a3e8..657f87b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2017-12-05 Simon Marchi + + * target-descriptions.c (struct tdesc_feature) : Use + tdesc_reg_up typedef. + (struct target_desc) : Use tdesc_feature_up typedef. + 2017-12-05 Simon Marchi * target-descriptions.c (struct tdesc_type): Use default @@ -118,6 +124,8 @@ (tdesc_register_in_reggroup_p): Adjust. (class print_c_tdesc) : Adjust. (class print_c_feature) : Adjust. + * features/arc-arcompact.c: Re-generate. + * features/arc-v2.c: Re-generate. 2017-12-05 Simon Marchi diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c index 12d72fa..5a6f619 100644 --- a/gdb/target-descriptions.c +++ b/gdb/target-descriptions.c @@ -529,7 +529,7 @@ struct tdesc_feature : tdesc_element std::string name; /* The registers associated with this feature. */ - std::vector> registers; + std::vector registers; /* The types associated with this feature. */ std::vector types; @@ -613,7 +613,7 @@ struct target_desc : tdesc_element std::vector properties; /* The features associated with this target. */ - std::vector> features; + std::vector features; void accept (tdesc_element_visitor &v) const override { -- 2.7.4