From 85222e4aa197701004beb7ab485e775ed9b11b9f Mon Sep 17 00:00:00 2001 From: Zaheer Abbas Merali Date: Tue, 15 Jun 2004 21:58:18 +0000 Subject: [PATCH] fixed a potential leak with previous commit Original commit message from CVS: 2004-06-15 Zaheer Abbas Merali fixed a potential leak with previous commit * gst-libs/gst/riff/riff-read.c: (gst_riff_peek_head): --- ChangeLog | 6 ++++++ gst-libs/gst/riff/riff-read.c | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 46617f0..e371768 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2004-06-15 Zaheer Abbas Merali + fixed a potential leak with previous commit + + * gst-libs/gst/riff/riff-read.c: (gst_riff_peek_head): + +2004-06-15 Zaheer Abbas Merali + * gst-libs/gst/riff/riff-read.c: (gst_riff_peek_head): Added missing refcount, fixes bug #144425 Cheers Tim for finding the bug diff --git a/gst-libs/gst/riff/riff-read.c b/gst-libs/gst/riff/riff-read.c index 6f5c5b2..be3e10d 100644 --- a/gst-libs/gst/riff/riff-read.c +++ b/gst-libs/gst/riff/riff-read.c @@ -180,9 +180,10 @@ gst_riff_peek_head (GstRiffRead * riff, /* Here, we might encounter EOS */ gst_bytestream_get_status (riff->bs, &remaining, &event); if (GST_IS_EVENT (event)) { - gst_event_ref (event); + gboolean eos = (GST_EVENT_TYPE (event) == GST_EVENT_EOS); + gst_pad_event_default (riff->sinkpad, event); - if (GST_EVENT_TYPE (event) == GST_EVENT_EOS) + if (eos) return FALSE; } else { GST_ELEMENT_ERROR (riff, RESOURCE, READ, (NULL), (NULL)); -- 2.7.4