From 846fd5abf2625c572e34c3e56d5537ef83815265 Mon Sep 17 00:00:00 2001 From: Jyothi Kumar Sambolu Date: Wed, 22 Feb 2017 19:50:37 +0530 Subject: [PATCH] Contains fixes to SQE review comments Change-Id: I660b75b795a3b7eacf111b88b115075fd9f91b69 Signed-off-by: Jyothi Kumar Sambolu --- packaging/csapi-account-fido-client.spec | 2 +- .../Tizen.Account.FidoClient/ErrorFactory.cs | 2 +- .../Tizen.Account.FidoClient/UafMessage.cs | 7 +++++++ .../Tizen.Account.FidoClient/UafResponse.cs | 7 +++++++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/packaging/csapi-account-fido-client.spec b/packaging/csapi-account-fido-client.spec index 55aca9d..517c494 100755 --- a/packaging/csapi-account-fido-client.spec +++ b/packaging/csapi-account-fido-client.spec @@ -8,7 +8,7 @@ Name: csapi-account-fido-client Summary: FIDO UAF C# API for Tizen -Version: 1.0.0 +Version: 1.0.1 Release: 1 Group: Development/Libraries License: Apache-2.0 diff --git a/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/ErrorFactory.cs b/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/ErrorFactory.cs index ab912d6..ef3191a 100755 --- a/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/ErrorFactory.cs +++ b/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/ErrorFactory.cs @@ -72,7 +72,7 @@ namespace Tizen.Account.FidoClient } else if ((FidoErrorCode)error == FidoErrorCode.ProtocolError) { - return new Exception("Protocol error, the interaction may have timed out, or the UAF message is malformed."); + return new ArgumentException("Protocol error, the interaction may have timed out, or the UAF message is malformed."); } else if ((FidoErrorCode)error == FidoErrorCode.UserCancelled) { diff --git a/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/UafMessage.cs b/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/UafMessage.cs index 9e60540..326c383 100755 --- a/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/UafMessage.cs +++ b/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/UafMessage.cs @@ -22,6 +22,13 @@ namespace Tizen.Account.FidoClient public class UafMessage { /// + /// The constructor + /// + public UafMessage() + { + } + + /// /// The FIDO message in JSON format which is received from the relying party server /// public string Operation { get; set; } diff --git a/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/UafResponse.cs b/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/UafResponse.cs index 4745749..ad85ac3 100755 --- a/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/UafResponse.cs +++ b/src/Tizen.Account.FidoClient/Tizen.Account.FidoClient/UafResponse.cs @@ -22,6 +22,13 @@ namespace Tizen.Account.FidoClient public class UafResponse { /// + /// The constructor + /// + public UafResponse() + { + } + + /// /// FIDO response message in JSON format /// public string Response { set; get; } -- 2.7.4