From 838486f43b395e48eac538bb687134ff0952808d Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 10 Jul 2020 13:28:03 -0400 Subject: [PATCH] [wasm] Addressing System.Runtime.InteropServices.RuntimeInformation.Tests failures (#39073) Co-authored-by: Mitchell Hwang --- .../tests/CheckArchitectureTests.cs | 4 ++++ .../tests/DescriptionNameTests.cs | 1 + .../tests/RuntimeIdentifierTests.cs | 1 + src/libraries/tests.proj | 1 - 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/CheckArchitectureTests.cs b/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/CheckArchitectureTests.cs index d97aaeb..4fa46f5 100644 --- a/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/CheckArchitectureTests.cs +++ b/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/CheckArchitectureTests.cs @@ -32,6 +32,10 @@ namespace System.Runtime.InteropServices.RuntimeInformationTests Assert.Equal(IntPtr.Size == 4 ? Architecture.Arm : Architecture.Arm64, processArch); break; + case Architecture.Wasm: + Assert.Equal(Architecture.Wasm, processArch); + break; + default: Assert.False(true, "Unexpected Architecture."); break; diff --git a/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/DescriptionNameTests.cs b/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/DescriptionNameTests.cs index ff2f617..7d0d5c4 100644 --- a/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/DescriptionNameTests.cs +++ b/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/DescriptionNameTests.cs @@ -12,6 +12,7 @@ namespace System.Runtime.InteropServices.RuntimeInformationTests public class DescriptionNameTests { [Fact] + [PlatformSpecific(~TestPlatforms.Browser)] // throws PNSE when binariesLocation is not an empty string. public void DumpRuntimeInformationToConsole() { // Not really a test, but useful to dump a variety of information to the test log to help diff --git a/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/RuntimeIdentifierTests.cs b/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/RuntimeIdentifierTests.cs index d25b747..6747714 100644 --- a/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/RuntimeIdentifierTests.cs +++ b/src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/RuntimeIdentifierTests.cs @@ -11,6 +11,7 @@ namespace System.Runtime.InteropServices.RuntimeInformationTests public class RuntimeIdentifierTests { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/39074", TestPlatforms.Browser)] public void VerifyOSRid() { Assert.NotNull(RuntimeInformation.RuntimeIdentifier); diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index c23f68c..9d88585 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -74,7 +74,6 @@ - -- 2.7.4