From 83655187cbef02404645abcc98d607e22eeda573 Mon Sep 17 00:00:00 2001 From: Doug Evans Date: Thu, 15 May 2014 15:45:05 -0700 Subject: [PATCH] * dwarf2read.c (read_structure_type): Delete outdated comments. --- gdb/ChangeLog | 4 ++++ gdb/dwarf2read.c | 13 ++++--------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d9e774a..f32d1f7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2014-05-15 Doug Evans + + * dwarf2read.c (read_structure_type): Delete outdated comments. + 2014-05-14 Tom Tromey * macrocmd.c (print_macro_definition): Reindent. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index bf1e3d0..5c8cfbd 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -12802,19 +12802,14 @@ producer_is_icc (struct dwarf2_cu *cu) /* Called when we find the DIE that starts a structure or union scope (definition) to create a type for the structure or union. Fill in the type's name and general properties; the members will not be - processed until process_structure_scope. + processed until process_structure_scope. A symbol table entry for + the type will also not be done until process_structure_scope (assuming + the type has a name). NOTE: we need to call these functions regardless of whether or not the DIE has a DW_AT_name attribute, since it might be an anonymous structure or union. This gets the type entered into our set of - user defined types. - - However, if the structure is incomplete (an opaque struct/union) - then suppress creating a symbol table entry for it since gdb only - wants to find the one with the complete definition. Note that if - it is complete, we just call new_symbol, which does it's own - checking about whether the struct/union is anonymous or not (and - suppresses creating a symbol table entry itself). */ + user defined types. */ static struct type * read_structure_type (struct die_info *die, struct dwarf2_cu *cu) -- 2.7.4