From 82f7144f791314885c0e4e86f16e579357bfe7e3 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Tue, 17 Aug 2021 16:28:09 -0500 Subject: [PATCH] [wasm] Enable tests blocked by IL2105 (#57457) * Disable ReflectionCachesUpdateHandler_CachesCleared with aggressive trimming * Enable more tests stopped by 2105 * Create tests.mobile.targets Suppress IL2025 * Remove comment enabling trim warnings * Mark more active issues --- eng/testing/tests.mobile.targets | 3 +-- .../tests/ReflectionCachesUpdateHandlerTests.cs | 1 + .../ObservableCollection_ConstructorAndPropertyTests.cs | 2 ++ .../tests/ObservableCollection/ObservableCollection_Serialization.cs | 1 + .../tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs | 3 +++ .../ReadOnlyObservableCollectionTests.cs | 2 ++ src/libraries/tests.proj | 5 ----- 7 files changed, 10 insertions(+), 7 deletions(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index 0cb9a22..fc196e0 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -13,8 +13,7 @@ true true - - $(NoWarn);IL2111 + $(NoWarn);IL2111;IL2105;IL2025 false diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs b/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs index 905a580..84a7069 100644 --- a/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs +++ b/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs @@ -11,6 +11,7 @@ namespace System.ComponentModel.Tests public class ReflectionCachesUpdateHandlerTests { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57456", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public void ReflectionCachesUpdateHandler_CachesCleared() { AttributeCollection ac1 = TypeDescriptor.GetAttributes(typeof(ReflectionCachesUpdateHandlerTests)); diff --git a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs index cd8a7be..c8a1e0a 100644 --- a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs +++ b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs @@ -118,6 +118,7 @@ namespace System.Collections.ObjectModel.Tests } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttributeTests() { ObservableCollection col = new ObservableCollection(new[] {1, 2, 3, 4}); @@ -129,6 +130,7 @@ namespace System.Collections.ObjectModel.Tests } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_NullCollection_ThrowsArgumentNullException() { TargetInvocationException ex = Assert.Throws(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ObservableCollection), null)); diff --git a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs index 65d5694..ad46a71 100644 --- a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs +++ b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs @@ -27,6 +27,7 @@ namespace System.Collections.ObjectModel.Tests } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public void OnDeserialized_MonitorNotInitialized_ExpectSuccess() { var observableCollection = new ObservableCollection(); diff --git a/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs b/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs index 0b7e426..dc30790 100644 --- a/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs +++ b/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs @@ -224,6 +224,7 @@ namespace System.Collections.ObjectModel.Tests } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttributeTests() { ReadOnlyDictionary dict = new ReadOnlyDictionary(new Dictionary{{1, 2}, {2, 4}, {3, 6}}); @@ -247,6 +248,7 @@ namespace System.Collections.ObjectModel.Tests } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_NullDictionary_ThrowsArgumentNullException() { TargetInvocationException ex = Assert.Throws(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyDictionary), null)); @@ -255,6 +257,7 @@ namespace System.Collections.ObjectModel.Tests } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException() { TargetInvocationException ex = Assert.Throws(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyDictionary.KeyCollection), new Type[] { typeof(int) }, null)); diff --git a/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs b/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs index 6cc4f2c..981caa7 100644 --- a/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs +++ b/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs @@ -197,6 +197,7 @@ namespace System.Collections.ObjectModel.Tests } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_Tests() { ReadOnlyObservableCollection col = new ReadOnlyObservableCollection(new ObservableCollection(new[] {1, 2, 3, 4})); @@ -208,6 +209,7 @@ namespace System.Collections.ObjectModel.Tests } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_NullCollection_ThrowsArgumentNullException() { TargetInvocationException ex = Assert.Throws(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyObservableCollection), null)); diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 1aac4ed..b5237fe 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -242,11 +242,6 @@ - - - - - -- 2.7.4