From 82c2e99102343f1538ae2ccdb15a0747d9510ca3 Mon Sep 17 00:00:00 2001 From: Bas Nieuwenhuizen Date: Sun, 30 Jan 2022 01:54:12 +0100 Subject: [PATCH] radv: Skip setting empty index buffers to avoid hang In the direct path we already skipped draws, but in DGC I noticed that just emitting these packets can cause issues ... Cc: mesa-stable Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_cmd_buffer.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 5ea72ba..8805995 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -2690,12 +2690,15 @@ radv_emit_index_buffer(struct radv_cmd_buffer *cmd_buffer, bool indirect) if (!indirect) return; - radeon_emit(cs, PKT3(PKT3_INDEX_BASE, 1, 0)); - radeon_emit(cs, state->index_va); - radeon_emit(cs, state->index_va >> 32); + if (state->max_index_count || + !cmd_buffer->device->physical_device->rad_info.has_zero_index_buffer_bug) { + radeon_emit(cs, PKT3(PKT3_INDEX_BASE, 1, 0)); + radeon_emit(cs, state->index_va); + radeon_emit(cs, state->index_va >> 32); - radeon_emit(cs, PKT3(PKT3_INDEX_BUFFER_SIZE, 0, 0)); - radeon_emit(cs, state->max_index_count); + radeon_emit(cs, PKT3(PKT3_INDEX_BUFFER_SIZE, 0, 0)); + radeon_emit(cs, state->max_index_count); + } cmd_buffer->state.dirty &= ~RADV_CMD_DIRTY_INDEX_BUFFER; } -- 2.7.4