From 82798eb7c9b45fba8aa45d6c5b9e8005a0f4c40d Mon Sep 17 00:00:00 2001 From: englebass Date: Thu, 19 Jan 2012 00:36:20 +0000 Subject: [PATCH] eina: Add FIXME git-svn-id: http://svn.enlightenment.org/svn/e/trunk/eina@67310 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- src/lib/eina_mmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/eina_mmap.c b/src/lib/eina_mmap.c index 4589818..7929f0e 100644 --- a/src/lib/eina_mmap.c +++ b/src/lib/eina_mmap.c @@ -164,6 +164,9 @@ eina_mmap_safety_enabled_set(Eina_Bool enabled) sa.sa_sigaction = _eina_mmap_safe_sigbus; sa.sa_flags = SA_RESTART | SA_SIGINFO; sigemptyset(&sa.sa_mask); + /* FIXME: This is rubbish. We return EINA_FALSE whether sigaction + * fails or not. And we never set mmap_safe, so we always hit this + * code path. */ if (sigaction(SIGBUS, &sa, NULL) == 0) return EINA_FALSE; /* setup of SIGBUS handler failed, lets close zero page dev and fail */ close(_eina_mmap_zero_fd); -- 2.7.4