From 823ed1e65175339143e68b195af416d11bc8f0d7 Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Sun, 1 Jul 2012 21:01:34 +0000 Subject: [PATCH] [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555 https://bugs.webkit.org/show_bug.cgi?id=90286 Patch by Konrad Piascik on 2012-07-01 Reviewed by Daniel Bates. Source/WebCore: Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes. * dom/ViewportArguments.h: (ViewportArguments): LayoutTests: Unskip now passing tests. * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/qt/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121635 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 13 +++++++++++++ LayoutTests/platform/efl/TestExpectations | 3 --- LayoutTests/platform/gtk/TestExpectations | 3 --- LayoutTests/platform/qt/TestExpectations | 3 --- Source/WebCore/ChangeLog | 13 +++++++++++++ Source/WebCore/dom/ViewportArguments.h | 2 +- 6 files changed, 27 insertions(+), 10 deletions(-) diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 997244d..fe5dc8c 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,16 @@ +2012-07-01 Konrad Piascik + + [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555 + https://bugs.webkit.org/show_bug.cgi?id=90286 + + Reviewed by Daniel Bates. + + Unskip now passing tests. + + * platform/efl/TestExpectations: + * platform/gtk/TestExpectations: + * platform/qt/TestExpectations: + 2012-06-30 Emil A Eklund Unreviewed chromium rebaseline for svg/zoom. diff --git a/LayoutTests/platform/efl/TestExpectations b/LayoutTests/platform/efl/TestExpectations index dcd66fc..de71f60 100644 --- a/LayoutTests/platform/efl/TestExpectations +++ b/LayoutTests/platform/efl/TestExpectations @@ -715,7 +715,4 @@ BUGWK89845 : fast/forms/input-set-composition-scroll.html = TEXT BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT -// Failing after r121555 -BUGWK90286 : fast/viewport/viewport-91.html = TEXT - BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations index 4299165..9c41157 100644 --- a/LayoutTests/platform/gtk/TestExpectations +++ b/LayoutTests/platform/gtk/TestExpectations @@ -1239,9 +1239,6 @@ BUGWK89845 : fast/forms/input-set-composition-scroll.html = TEXT BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT -// Failing after r121555 -BUGWK90286 : fast/viewport/viewport-91.html = TEXT - BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE ////////////////////////////////////////////////////////////////////////////////////////// diff --git a/LayoutTests/platform/qt/TestExpectations b/LayoutTests/platform/qt/TestExpectations index 4c56a58..d5b99ac 100644 --- a/LayoutTests/platform/qt/TestExpectations +++ b/LayoutTests/platform/qt/TestExpectations @@ -101,6 +101,3 @@ BUGWK85463 SKIP : editing/inserting/typing-space-to-trigger-smart-link.html = PA BUGWK88794 SKIP : webaudio/codec-tests = PASS BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT - -// Failing after r121555 -BUGWK90286 : fast/viewport/viewport-91.html = TEXT diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index caf8a45..ab33aaf 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,16 @@ +2012-07-01 Konrad Piascik + + [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555 + https://bugs.webkit.org/show_bug.cgi?id=90286 + + Reviewed by Daniel Bates. + + Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result + was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes. + + * dom/ViewportArguments.h: + (ViewportArguments): + 2012-06-30 Ian Vollick [chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content space. diff --git a/Source/WebCore/dom/ViewportArguments.h b/Source/WebCore/dom/ViewportArguments.h index b6293ef..bb13e6a 100644 --- a/Source/WebCore/dom/ViewportArguments.h +++ b/Source/WebCore/dom/ViewportArguments.h @@ -110,7 +110,7 @@ struct ViewportArguments { } // FIXME: We're going to keep this constant around until all embedders // refactor their code to no longer need it. - static const int deprecatedTargetDPI = 160; + static const float deprecatedTargetDPI = 160; }; ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport); -- 2.7.4