From 820396b93ae48680dd536704be80809b52f1639e Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C5=81ukasz=20Stelmach?= Date: Fri, 9 Apr 2021 16:59:56 +0200 Subject: [PATCH] logger: adapt access mode checks MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Allow setting the tag and the priority only for files opened O_WRONLY. Change-Id: Icc9d7a8eb96f8f1b1aa00717aae1f32f7a2e52e4 Signed-off-by: Łukasz Stelmach --- drivers/staging/android/logger.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c index fb6afb3..67608e0 100644 --- a/drivers/staging/android/logger.c +++ b/drivers/staging/android/logger.c @@ -957,7 +957,8 @@ static long logger_ioctl(struct file *file, unsigned int cmd, unsigned long arg) ret = logger_set_version(reader, argp); break; case LOGGER_SET_PRIO: /* 44552 */ - if (file->f_mode & FMODE_READ) { + if ((file->f_mode & FMODE_READ) || + !(file->f_mode & FMODE_WRITE)) { ret = -EBADF; break; } @@ -965,7 +966,8 @@ static long logger_ioctl(struct file *file, unsigned int cmd, unsigned long arg) ret = logger_set_prio(writer, argp); break; case LOGGER_SET_TAG: /* 44551 */ - if (file->f_mode & FMODE_READ) { + if ((file->f_mode & FMODE_READ) || + !(file->f_mode & FMODE_WRITE)) { ret = -EBADF; break; } -- 2.34.1