From 81f0f78965ebfe48c4997801050f64687cebea48 Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Sun, 2 Aug 2020 14:16:12 +0300 Subject: [PATCH] Revert "serial: 8250: Let serial core initialise spin lock" This reverts commit 679193b7baf8d88e41cbeb397ca17f797654947d. It appears that in QEmu the lock has been initialised differently (it wasn't obvious on real hardware during testing). Let's revert the change until the better approach will be developed. Reported-by: kernel test robot Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200802111612.36189-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/8250/8250_port.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index b2d1818..0947569 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -3194,6 +3194,7 @@ void serial8250_init_port(struct uart_8250_port *up) { struct uart_port *port = &up->port; + spin_lock_init(&port->lock); port->ops = &serial8250_pops; port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE); -- 2.7.4