From 81e4da72a883ef860542d12e848f8cca2da8d78b Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Wed, 27 Sep 2017 10:37:56 +0200 Subject: [PATCH] Remove test cases for doubles from varying components test Usage of the component layout qualifier (introduced with ARB_enhanced_layouts) with double types has specific rules and restrictions (see page 67 of the GLSL 4.60 spec), but the tests ignore all of these completely and just follow the same code paths we use for single-precision types, making the resulting shaders completely bogus. Remove these tests until we can provide new ones that make sense for double precision and follow the specs. Components: OpenGL VK-GL-CTS issue: 714 Affects: KHR-GL45.enhanced_layouts.varying_components KHR-GL46.enhanced_layouts.varying_components Change-Id: I2d3c1c645f5a18a83feee5c7b28cb023bd255808 --- external/openglcts/modules/gl/gl4cEnhancedLayoutsTests.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/external/openglcts/modules/gl/gl4cEnhancedLayoutsTests.cpp b/external/openglcts/modules/gl/gl4cEnhancedLayoutsTests.cpp index c22db73..4ef77c4 100644 --- a/external/openglcts/modules/gl/gl4cEnhancedLayoutsTests.cpp +++ b/external/openglcts/modules/gl/gl4cEnhancedLayoutsTests.cpp @@ -14808,14 +14808,7 @@ glw::GLuint VaryingComponentsTest::getTestCaseNumber() /* Prepare test cases */ void VaryingComponentsTest::testInit() { - m_test_cases.push_back(testCase(GVEC4, Utils::Type::Double)); - m_test_cases.push_back(testCase(SCALAR_GVEC3, Utils::Type::Double)); - m_test_cases.push_back(testCase(GVEC3_SCALAR, Utils::Type::Double)); - m_test_cases.push_back(testCase(GVEC2_GVEC2, Utils::Type::Double)); - m_test_cases.push_back(testCase(GVEC2_SCALAR_SCALAR, Utils::Type::Double)); - m_test_cases.push_back(testCase(SCALAR_GVEC2_SCALAR, Utils::Type::Double)); - m_test_cases.push_back(testCase(SCALAR_SCALAR_GVEC2, Utils::Type::Double)); - m_test_cases.push_back(testCase(SCALAR_SCALAR_SCALAR_SCALAR, Utils::Type::Double)); + // FIXME: add tests for doubles, which have specific rules m_test_cases.push_back(testCase(GVEC4, Utils::Type::Float)); m_test_cases.push_back(testCase(SCALAR_GVEC3, Utils::Type::Float)); -- 2.7.4