From 81db75c6aef06ab0699690ad290a6853f2088711 Mon Sep 17 00:00:00 2001 From: Jeff Donahue Date: Tue, 8 Apr 2014 04:25:20 -0700 Subject: [PATCH] gpu_hamming_distance fails unit test with fixed RNG; mark it NOT_IMPLEMENTED with TODO to fix and disable its unit test --- src/caffe/test/test_math_functions.cpp | 3 ++- src/caffe/util/math_functions.cu | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/caffe/test/test_math_functions.cpp b/src/caffe/test/test_math_functions.cpp index 2c2c062..3ddd320 100644 --- a/src/caffe/test/test_math_functions.cpp +++ b/src/caffe/test/test_math_functions.cpp @@ -81,7 +81,8 @@ TYPED_TEST(MathFunctionsTest, TestHammingDistanceCPU) { caffe_cpu_hamming_distance(n, x, y)); } -TYPED_TEST(MathFunctionsTest, TestHammingDistanceGPU) { +// TODO: Fix caffe_gpu_hamming_distance and re-enable this test. +TYPED_TEST(MathFunctionsTest, DISABLED_TestHammingDistanceGPU) { int n = this->blob_bottom_->count(); const TypeParam* x = this->blob_bottom_->cpu_data(); const TypeParam* y = this->blob_top_->cpu_data(); diff --git a/src/caffe/util/math_functions.cu b/src/caffe/util/math_functions.cu index 0ac10d9..40c4f50 100644 --- a/src/caffe/util/math_functions.cu +++ b/src/caffe/util/math_functions.cu @@ -159,6 +159,9 @@ __global__ void popcll_kernel(const int n, const double* a, template <> uint32_t caffe_gpu_hamming_distance(const int n, const float* x, const float* y) { + // TODO: Fix caffe_gpu_hamming_distance (see failing unit test + // TestHammingDistanceGPU in test_math_functions.cpp). + NOT_IMPLEMENTED; thrust::device_vector popcounts(n); // NOLINT_NEXT_LINE(whitespace/operators) popc_kernel<<>>( @@ -170,6 +173,9 @@ uint32_t caffe_gpu_hamming_distance(const int n, const float* x, template <> uint32_t caffe_gpu_hamming_distance(const int n, const double* x, const double* y) { + // TODO: Fix caffe_gpu_hamming_distance (see failing unit test + // TestHammingDistanceGPU in test_math_functions.cpp). + NOT_IMPLEMENTED; thrust::device_vector popcounts(n); // NOLINT_NEXT_LINE(whitespace/operators) popcll_kernel<<>>( -- 2.7.4