From 81d351b5f0f508c7000e0ec8ee11d79461c9b7a6 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Mon, 19 Dec 2011 11:03:55 +0100 Subject: [PATCH] tagdemux: add FIXME Add a FIXME because the EOS before-type case now has to be solved differently because the srcpad is always available. --- gst-libs/gst/tag/gsttagdemux.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gst-libs/gst/tag/gsttagdemux.c b/gst-libs/gst/tag/gsttagdemux.c index 04e9c46..e37edb0 100644 --- a/gst-libs/gst/tag/gsttagdemux.c +++ b/gst-libs/gst/tag/gsttagdemux.c @@ -646,11 +646,6 @@ gst_tag_demux_chain (GstPad * pad, GstObject * parent, GstBuffer * buf) return GST_FLOW_EOS; } if (outbuf) { - if (G_UNLIKELY (demux->priv->srcpad == NULL)) { - gst_buffer_unref (outbuf); - return GST_FLOW_ERROR; - } - /* Might need a new segment before the buffer */ if (demux->priv->need_newseg) { if (!gst_tag_demux_send_new_segment (demux)) { @@ -688,6 +683,7 @@ gst_tag_demux_sink_event (GstPad * pad, GstObject * parent, GstEvent * event) switch (GST_EVENT_TYPE (event)) { case GST_EVENT_EOS: + /* FIXME, detect this differently */ if (demux->priv->srcpad == NULL) { GST_WARNING_OBJECT (demux, "EOS before we found a type"); GST_ELEMENT_ERROR (demux, STREAM, TYPE_NOT_FOUND, (NULL), (NULL)); -- 2.7.4