From 81b9222220c55933198d7d1db7d618d9baf75550 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Sun, 7 Jun 2009 19:07:08 +0000 Subject: [PATCH] * auxv.c (procfs_xfer_auxv): Change type of the `object' argument to enum target_object. Cleanup comments. * auxv.h: Include "target.h". Cleanup comments to not mention NATIVE_XFER_AUXV anymore. --- gdb/ChangeLog | 7 +++++++ gdb/auxv.c | 11 ++++------- gdb/auxv.h | 21 ++++++--------------- 3 files changed, 17 insertions(+), 22 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5703caf..a804dad 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +20009-06-07 Pedro Alves + + * auxv.c (procfs_xfer_auxv): Change type of the `object' argument + to enum target_object. Cleanup comments. + * auxv.h: Include "target.h". Cleanup comments to not mention + NATIVE_XFER_AUXV anymore. + 2009-06-07 Pedro Alves * inferior.h (procfs_first_available): Move declaration to... diff --git a/gdb/auxv.c b/gdb/auxv.c index 3a51ec5..f8eb6ef 100644 --- a/gdb/auxv.c +++ b/gdb/auxv.c @@ -33,16 +33,13 @@ #include -/* This function is called like a to_xfer_partial hook, - but must be called with TARGET_OBJECT_AUXV. - It handles access via /proc/PID/auxv, which is the common method. - This function is appropriate for doing: - #define NATIVE_XFER_AUXV procfs_xfer_auxv - for a native target that uses inftarg.c's child_xfer_partial hook. */ +/* This function is called like a to_xfer_partial hook, but must be + called with TARGET_OBJECT_AUXV. It handles access via + /proc/PID/auxv, which is a common method for native targets. */ LONGEST procfs_xfer_auxv (struct target_ops *ops, - int /* enum target_object */ object, + enum target_object object, const char *annex, gdb_byte *readbuf, const gdb_byte *writebuf, diff --git a/gdb/auxv.h b/gdb/auxv.h index 16618c8..71e6562 100644 --- a/gdb/auxv.h +++ b/gdb/auxv.h @@ -21,14 +21,9 @@ #ifndef AUXV_H #define AUXV_H -/* See "include/elf/common.h" for the definition of valid AT_* values. */ - - -/* Avoid miscellaneous includes in this file, so that it can be - included by nm-*.h for the procfs_xfer_auxv decl if that is - used in NATIVE_XFER_AUXV. */ -struct target_ops; /* Forward declaration. */ +#include "target.h" +/* See "include/elf/common.h" for the definition of valid AT_* values. */ /* Read one auxv entry from *READPTR, not reading locations >= ENDPTR. Return 0 if *READPTR is already at the end of the buffer. @@ -48,16 +43,12 @@ extern int target_auxv_search (struct target_ops *ops, /* Print the contents of the target's AUXV on the specified file. */ extern int fprint_target_auxv (struct ui_file *file, struct target_ops *ops); - -/* This function is called like a to_xfer_partial hook, - but must be called with TARGET_OBJECT_AUXV. - It handles access via /proc/PID/auxv, which is the common method. - This function is appropriate for doing: - #define NATIVE_XFER_AUXV procfs_xfer_auxv - for a native target that uses inftarg.c's child_xfer_partial hook. */ +/* This function is called like a to_xfer_partial hook, but must be + called with TARGET_OBJECT_AUXV. It handles access via + /proc/PID/auxv, which is a common method for native targets. */ extern LONGEST procfs_xfer_auxv (struct target_ops *ops, - int /* enum target_object */ object, + enum target_object object, const char *annex, gdb_byte *readbuf, const gdb_byte *writebuf, -- 2.7.4