From 81298056a78c5163b216f17d17c43736e7069961 Mon Sep 17 00:00:00 2001 From: Matt Roper Date: Tue, 7 Jun 2022 08:47:24 -0700 Subject: [PATCH] drm/i915/dg2: Correct DSS check for Wa_1308578152 When converting our DSS masks to bitmaps, we fumbled the condition used to check whether any DSS are present in the first gslice. Since intel_sseu_find_first_xehp_dss() returns a 0-based number, we need a >= condition rather than >. Fixes: b87d39019651 ("drm/i915/sseu: Disassociate internal subslice mask representation from uapi") Reported-by: Balasubramani Vivekanandan Signed-off-by: Matt Roper Acked-by: Balasubramani Vivekanandan Link: https://patchwork.freedesktop.org/patch/msgid/20220607154724.3155521-1-matthew.d.roper@intel.com --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index 1e7ca38..0ac7f5d 100644 --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c @@ -2062,7 +2062,7 @@ engine_fake_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) static bool needs_wa_1308578152(struct intel_engine_cs *engine) { - return intel_sseu_find_first_xehp_dss(&engine->gt->info.sseu, 0, 0) > + return intel_sseu_find_first_xehp_dss(&engine->gt->info.sseu, 0, 0) >= GEN_DSS_PER_GSLICE; } -- 2.7.4