From 80f06ab362ec4ddda48eaa5374ce41ccd3478735 Mon Sep 17 00:00:00 2001
From: Piotr Kosko
Date: Thu, 26 Mar 2020 08:41:59 +0100
Subject: [PATCH] [Alarm] Fixed Coverity issue and undefined behaviour
[Coverity] 1134493
Change-Id: I3c9aa41a640efc6ca001ea96978374994a88e029
---
src/alarm/alarm_manager.cc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/alarm/alarm_manager.cc b/src/alarm/alarm_manager.cc
index c9690ce1..7a231819 100644
--- a/src/alarm/alarm_manager.cc
+++ b/src/alarm/alarm_manager.cc
@@ -365,7 +365,11 @@ PlatformResult AlarmManager::GetAlarm(int id, picojson::object& obj) {
int interval = 0;
- app_control_get_extra_data(app_control, kAlarmAbsoluteRecurrenceTypeKey, &alarm_type);
+ ret = app_control_get_extra_data(app_control, kAlarmAbsoluteRecurrenceTypeKey, &alarm_type);
+ if (APP_CONTROL_ERROR_NONE != ret) {
+ return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Unknown error occurred.",
+ ("Getting data failed: %d (%s)", ret, get_error_message(ret)));
+ }
if (!strcmp(alarm_type, kAlarmAbsoluteReccurrenceTypeInterval)) {
ret = alarm_get_scheduled_period(id, &interval);
--
2.34.1