From 80a26036b8da4e65642ae9205928173a64a15755 Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Fri, 13 Apr 2012 10:10:41 +0000 Subject: [PATCH] Web Inspector: Line number is not displayed while debugging javascript https://bugs.webkit.org/show_bug.cgi?id=83786 Patch by Vivek Galatage on 2012-04-13 Reviewed by Pavel Feldman. Changed the textViewer.css to start displaying the line number with appropriate color property. Added outline property for enhanced view No additional test cases required for the above fix. * inspector/front-end/Images/breakpointConditionalCounterBorder.png: * inspector/front-end/Images/breakpointCounterBorder.png: * inspector/front-end/Images/programCounterBorder.png: * inspector/front-end/textViewer.css: (.webkit-execution-line .webkit-line-number-outer): (.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer): (.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114103 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 20 ++++++++++++++++++++ .../Images/breakpointConditionalCounterBorder.png | Bin 422 -> 444 bytes .../front-end/Images/breakpointCounterBorder.png | Bin 414 -> 460 bytes .../front-end/Images/programCounterBorder.png | Bin 331 -> 319 bytes Source/WebCore/inspector/front-end/textViewer.css | 12 +++++++++--- 5 files changed, 29 insertions(+), 3 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 53c8aa6..f3e410e 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,23 @@ +2012-04-13 Vivek Galatage + + Web Inspector: Line number is not displayed while debugging javascript + https://bugs.webkit.org/show_bug.cgi?id=83786 + + Reviewed by Pavel Feldman. + + Changed the textViewer.css to start displaying the line number with + appropriate color property. Added outline property for enhanced view + + No additional test cases required for the above fix. + + * inspector/front-end/Images/breakpointConditionalCounterBorder.png: + * inspector/front-end/Images/breakpointCounterBorder.png: + * inspector/front-end/Images/programCounterBorder.png: + * inspector/front-end/textViewer.css: + (.webkit-execution-line .webkit-line-number-outer): + (.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer): + (.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer): + 2012-04-13 Kent Tamura Add a runtime flag for diff --git a/Source/WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png b/Source/WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png index a173c9d2067affadf6bcc4ca2ef75d3d1616b365..03b64128bb4285783be37e6aa089ea13317192d4 100644 GIT binary patch delta 418 zcmV;T0bTy41H1!}B!2{FK}|sb0I`n?{9y$E000SaNLh0L01FZT01FZU(%pXi00007 zbV*G`2igMx6bU=~i_x6`000_vMObuGZ)S9NVRB^vP+@6qbS_RsR3LUUE;TMOFfjCT zp#T5@B}qgFGSsE~oBhmqko2=_BF%znPEc=zo-`+u_+3WXn?Nn`kWHl5)= zsrY;`!xo%=`G2yG31%UPUa7{g?d7(@{r6_sT))~P^yXp}!~aVpVvqwblrqf3uoT%M zWcF4EhApr5WL&sEPwmN#UWWfS`xyR_f-e+8LIr4P9g3wmEd0~U#PDlhFvHPD%Pk+0 zW8sY+hX3dDfPa=|0O>M@G`OW$Eo5T+3l#s;$HMUYXbQt!ax4Ue#*Hq9|L1bRmi{|e z#^4RM6rY7XObmY~^Dz7ZY9={IVZnd31roGC-+lyJIyig?3{FrS?hR%*LX|iyWk|sv zhrp}>N~JHhgr1>#D*e*UzyZvMI&{m2Ag=;T8b-R7G#dj^oYKus0B2l8JliQ*umAu6 M07*qoM6N<$f?B+?eE$zUzFN(2_C_tk{0B`8xnH^&oc^Dz3x!z-!jl*n8Zaz{S$3nB z;or?Z;xJI{k6V2V5AOCe?0hnnq4E0y22W&*knpd`Obi)NOO@ajf?Q3kWl#%011-FH zZvw-LmophM|9_uJ3&mj}2!Ef-%n$p2^Jq!$A zfWhlXwuQI)89v^gz;N;5WQLg^<}!r+f4-vwuZ2L|%gFGIem-Pm_)3uvNsYsa3=F|2 qaY%<$>H<%tbkB!$FKLD~003~?Zkq&h_ACGZ002ovP6b4+LSTZfi>QMD diff --git a/Source/WebCore/inspector/front-end/Images/breakpointCounterBorder.png b/Source/WebCore/inspector/front-end/Images/breakpointCounterBorder.png index d078545e1fac1d6801fd89f0a906b932752261a7..4fe9e061daaf55c0389b04e6be6a294c8e136ad6 100644 GIT binary patch delta 434 zcmV;j0Zsm%1Iz=EB!2{FK}|sb0I`n?{9y$E000SaNLh0L01FZT01FZU(%pXi00007 zbV*G`2igMx6bU=~i_x6`000_vMObuGZ)S9NVRB^vP+@6qbS_RsR3LUUE;TMOFfjCT zp#T5@HAzH4R5(v#U>FGSsE~oBhmqko2=_BF%r0K{e7Aky?SHevg%=(%q@DT7kbd?L z5dS9$7oXpP(=Y!|)-k~>1kq_~PTLB%z1(jz>)v&tmaA_VsxJOwsJir@Bn)z3>4ljX zmLgjOV|N2B4RJ`=lCkI21+{tipD^^^_`%S3^B+mL@B$=6N-xx*Sc=_3#y?$5Ouy`d z>yKJ4fAkP&;eTh6ECV^N=f;1Ayz~DVGJuwrolk>Xip|0vCZ@kYU;gP}Vf(F>GV3l` z7J@A80$Q4L4rJ*+hO%?sU`z2?*u}*7w~`X=lDNq@8`hka^(%L-v)K40*ST7z!Un^e{5~2H}1thJV@r|NjpKVq+i{#I&sV z!heRUOGM&}zZj}7y=JJsdX}N~#(ajR2e}O0U!3Yr{tty&2*Q&X7#c7wg;~~n;~zuc zP2zCxjUNnsw;nL`-`&YD^+_Ycg72Ql79rtZlbIMYpq45jECjilSj!+5eg;~2lVQTW z6$~?9W~QA%^?Vr`{yvqNAq3=03N5^SiDB}CISg~&Mz4JMzZ{Q+zk3)Mz5s*Qk$emL zZ+&E#aQh;|7EbiUeXL_001BkZkteHWOD!j002ovPDHLkV1n3>qg((0 diff --git a/Source/WebCore/inspector/front-end/Images/programCounterBorder.png b/Source/WebCore/inspector/front-end/Images/programCounterBorder.png index 5e7717ef89c005a5e6f3f67d376b5861a7fb54ba..96ce1f07a12affcac4f1b93b5337cc4d8000c2aa 100644 GIT binary patch delta 292 zcmV+<0o(q|0>1)~B!2{FK}|sb0I`n?{9y$E000SaNLh0L01FZT01FZU(%pXi00007 zbV*G`2igMx6bU=~i_x6`000_vMObuGZ)S9NVRB^vP+@6qbS_RsR3LUUE;TMOFfjCT zp#T5?s7XXYR5(v#U>FGSsE~oBhmqko2=_BF%>MuXe<%=_1Ann25DQY>P5)2UF~KYZ z(UTY$8h{pUfLdxuRSS_VLSp|qQCE8wXyFnd_M?Y|zx&wP{+?-TSr4=@lP(tavM~Sa zXJ`L?ytcN1ZWi`1GyR>w$?=YE76OBnem(@n;i~l{5 delta 304 zcmdnbbed^`NGZx^prw85kH8l0AZa85pY67#JE_7#My5g&JNkFq9fFFuY1& zV6d9Oz#v{QXIG#NP=YPV+ueoXKL{?^yL>WGgtNdSvY3H^TNs2H8D`Cq01C2~c>21s z-(qGI;WED|aIO?6G~d(3F~p)bIYA=pLH+;#|C=0gc#bS|h~Yb8TrDA4*IZyPd^l%? zg-6_kC^0QZ-nR^oLLK%QL6PWOLMWW(~r^byxc;vY2zZ)3TFtV*z{;R|CD9)`d{mYgQ+FNTpLS+0> w5;QrMg~FVdQ&MBb@08TAub^rhX diff --git a/Source/WebCore/inspector/front-end/textViewer.css b/Source/WebCore/inspector/front-end/textViewer.css index 95066a7..5fae556 100644 --- a/Source/WebCore/inspector/front-end/textViewer.css +++ b/Source/WebCore/inspector/front-end/textViewer.css @@ -138,7 +138,9 @@ } .webkit-execution-line .webkit-line-number-outer { - color: transparent; + color: rgb(142, 5, 4); + font-weight: bold; + outline: 1px solid rgb(64, 115, 244); border-width: 0 14px 0px 2px; -webkit-border-image: url(Images/programCounterBorder.png) 0 14 0 2; } @@ -149,12 +151,16 @@ } .webkit-breakpoint.webkit-execution-line .webkit-line-number-outer { - color: transparent; + color: white; + font-weight: bold; + outline: 1px solid rgb(64, 115, 244); -webkit-border-image: url(Images/breakpointCounterBorder.png) 0 14 0 2; } .webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer { - color: transparent; + color: white; + font-weight: bold; + outline: 1px solid rgb(64, 115, 244); -webkit-border-image: url(Images/breakpointConditionalCounterBorder.png) 0 14 0 2; } -- 2.7.4