From 80524fb3da137177be2102cdd4b3d1401ba2f94a Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Thu, 7 May 2020 07:43:30 -0400 Subject: [PATCH] h264parser: Removed impossible error case Same as done for H264, this error was trying to catch the case where we had a start code without any bytes afterward. This will never happen since the start code scanner only returns a match if there is one byte after start code (pattern 0x00000100 / mask 0xffffff00). In H264, once byte is sufficient to identify the NALU. Part-of: --- gst-libs/gst/codecparsers/gsth264parser.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/gst-libs/gst/codecparsers/gsth264parser.c b/gst-libs/gst/codecparsers/gsth264parser.c index 63d96fb..44dcc7e 100644 --- a/gst-libs/gst/codecparsers/gsth264parser.c +++ b/gst-libs/gst/codecparsers/gsth264parser.c @@ -1444,12 +1444,6 @@ gst_h264_parser_identify_nalu_unchecked (GstH264NalParser * nalparser, return GST_H264_PARSER_NO_NAL; } - if (offset + off1 == size - 1) { - GST_DEBUG ("Missing data to identify nal unit"); - - return GST_H264_PARSER_ERROR; - } - nalu->sc_offset = offset + off1; /* sc might have 2 or 3 0-bytes */ -- 2.7.4