From 803761a9f97cfe1ae70aee9d59741a0f12f20964 Mon Sep 17 00:00:00 2001 From: "weiliang.lin@intel.com" Date: Tue, 23 Sep 2014 03:55:35 +0000 Subject: [PATCH] X87: Further improve deopt reason output port r24123. R24123 does not cover all required code change in X87. original commit message: Further improve deopt reason output. * Make the detailed deopt reason mandatory on x64, other platforms will follow in separate CLs. * Extracted and improved jump table entry sharing logic: When --trace-deopt is on, we get separate entries for different deopt reasons. This enables us to distinguish the several reasons single instructions can have. * Don't emit superfluous jump table comments: The bailout ID is still visible, and the jump table entry number is not interesting (but easy to determine if really needed). * Unify the internal name of the jump table member across platforms. BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/589313002 Patch from Chunyang Dai . git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/x87/lithium-codegen-x87.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc index 40926cd..ff68fd0 100644 --- a/src/x87/lithium-codegen-x87.cc +++ b/src/x87/lithium-codegen-x87.cc @@ -383,9 +383,6 @@ bool LCodeGen::GenerateJumpTable() { Deoptimizer::JumpTableEntry* table_entry = &jump_table_[i]; __ bind(&table_entry->label); Address entry = table_entry->address; - Deoptimizer::BailoutType type = table_entry->bailout_type; - int id = Deoptimizer::GetDeoptimizationId(isolate(), entry, type); - DCHECK_NE(Deoptimizer::kNotDeoptimizationEntry, id); DeoptComment(table_entry->reason); if (table_entry->needs_frame) { DCHECK(!info()->saves_caller_doubles()); -- 2.7.4