From 801971e5b4c026a7941749cc1b3c7ac562577dda Mon Sep 17 00:00:00 2001 From: =?utf8?q?Martin=20Storsj=C3=B6?= Date: Mon, 18 Jul 2022 09:27:11 +0300 Subject: [PATCH] [LLD] [COFF] Improve the error message for too many exported symbols Print the actual number of symbols that would have been exported too, which helps assessing the situation. Differential Revision: https://reviews.llvm.org/D130117 --- lld/COFF/DriverUtils.cpp | 2 +- lld/test/COFF/export-limit.s | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lld/COFF/DriverUtils.cpp b/lld/COFF/DriverUtils.cpp index ac0f1f9..dbfbec1 100644 --- a/lld/COFF/DriverUtils.cpp +++ b/lld/COFF/DriverUtils.cpp @@ -709,7 +709,7 @@ void assignExportOrdinals() { if (e.ordinal == 0) e.ordinal = ++max; if (max > std::numeric_limits::max()) - fatal("too many exported symbols (max " + + fatal("too many exported symbols (got " + Twine(max) + ", max " + Twine(std::numeric_limits::max()) + ")"); } diff --git a/lld/test/COFF/export-limit.s b/lld/test/COFF/export-limit.s index 8936754..baf1f5d 100644 --- a/lld/test/COFF/export-limit.s +++ b/lld/test/COFF/export-limit.s @@ -5,7 +5,7 @@ # RUN: lld-link -dll -noentry %t.obj -out:%t.dll -def:%t-65535.def # RUN: env LLD_IN_TEST=1 not lld-link -dll -noentry %t.obj -out:%t.dll -def:%t-65536.def 2>&1 | FileCheck %s -# CHECK: error: too many exported symbols +# CHECK: error: too many exported symbols (got 65536, max 65535) .text .globl f -- 2.7.4