From 7fe958be01489f0309b1b822b7cb191ccafe23af Mon Sep 17 00:00:00 2001 From: Elena Zannoni Date: Fri, 10 Oct 2003 19:20:31 +0000 Subject: [PATCH] 2003-10-10 Elena Zannoni * sh-tdep.c (sh_use_struct_convention): Clarify one case in comment. --- gdb/ChangeLog | 5 +++++ gdb/sh-tdep.c | 12 +++++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d170797..5bc5854 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2003-10-10 Elena Zannoni + + * sh-tdep.c (sh_use_struct_convention): Clarify one case in + comment. + 2003-10-10 Corinna Vinschen * sh-tdep.c (sh_use_struct_convention): Clean up to have a diff --git a/gdb/sh-tdep.c b/gdb/sh-tdep.c index eee7698..3d8c629 100644 --- a/gdb/sh-tdep.c +++ b/gdb/sh-tdep.c @@ -568,7 +568,7 @@ sh_skip_prologue (CORE_ADDR start_pc) All other aggregate types are returned by address. The caller function passes the address of an area large enough to hold the aggregate value in R2. The called function stores the result in - this location." + this location. To reiterate, structs smaller than 8 bytes could also be returned in memory, if they don't pass the "same size and alignment as an @@ -582,6 +582,16 @@ sh_skip_prologue (CORE_ADDR start_pc) the return value from foo() will be in memory, not in R0, because there is no 3-byte integer type. + Similarly, in + + struct s { char c[2]; } wibble; + struct s foo(void) { return wibble; } + + because a struct containing two chars has alignment 1, that matches + type char, but size 2, that matches type short. There's no integer + type that has alignment 1 and size 2, so the struct is returned in + memory. + */ static int -- 2.7.4