From 7fc225f8c4596d4e51d64e814b21cc49c5e8566b Mon Sep 17 00:00:00 2001 From: Nicolas Vasilache Date: Fri, 29 May 2020 17:29:35 -0400 Subject: [PATCH] [mlir] Fix Windows build Summary: MSVC does not seem to like certain forward declarations. https://reviews.llvm.org/D80728 introduces an error where seemingly unrelated .cpp files that include the .h (but do not otherwise use the class that depends on the forward declaration). Instead of forward declaration, include the full vector ops definition. Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D80841 --- mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h index 2e6a859..fb8fc4c 100644 --- a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h +++ b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h @@ -10,17 +10,11 @@ #define DIALECT_LINALG_TRANSFORMS_TRANSFORMS_H_ #include "mlir/Dialect/Linalg/Utils/Utils.h" +#include "mlir/Dialect/Vector/VectorOps.h" #include "mlir/IR/PatternMatch.h" #include "llvm/ADT/SmallBitVector.h" namespace mlir { -namespace vector { - -class TransferReadOp; -class TransferWriteOp; - -} // namespace vector - namespace linalg { struct LinalgTilingOptions; -- 2.7.4