From 7f7409baf4fbb7f01adaffddbb953105490ae82a Mon Sep 17 00:00:00 2001 From: Mike McLaughlin Date: Thu, 20 Jun 2019 18:06:28 -0700 Subject: [PATCH] Fix UNKNOWN types in dumpheap -stat (#355) Issue https://github.com/dotnet/diagnostics/issues/350 --- src/SOS/Strike/util.cpp | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/SOS/Strike/util.cpp b/src/SOS/Strike/util.cpp index f45ecc080..f0843b6bc 100644 --- a/src/SOS/Strike/util.cpp +++ b/src/SOS/Strike/util.cpp @@ -6333,20 +6333,8 @@ void PopulateMetadataRegions() { if (moduleData.metadataStart != 0) { - bool add = false; - STORAGESIGNATURE header; - if (SUCCEEDED(g_ExtData->ReadVirtual(moduleData.metadataStart, (PVOID)&header, sizeof(header), NULL))) - { - add = header.lSignature != STORAGE_MAGIC_SIG; - } - else { - add = true; - } - if (add) - { - MemoryRegion region(moduleData.metadataStart, moduleData.metadataStart + moduleData.metadataSize); - g_metadataRegions.insert(region); - } + MemoryRegion region(moduleData.metadataStart, moduleData.metadataStart + moduleData.metadataSize); + g_metadataRegions.insert(region); #ifdef METADATA_REGION_LOGGING ArrayHolder name = new WCHAR[MAX_LONGPATH]; name[0] = '\0'; -- 2.34.1