From 7f64aa017f04904f6b66aec5c12da694d7358274 Mon Sep 17 00:00:00 2001 From: "verwaest@chromium.org" Date: Wed, 27 Aug 2014 11:42:17 +0000 Subject: [PATCH] Remove false checks since GetOwnProperty now throws an exception on access check violation. BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/514613002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23452 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/v8natives.js | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/v8natives.js b/src/v8natives.js index 00d8a88..a522738 100644 --- a/src/v8natives.js +++ b/src/v8natives.js @@ -571,10 +571,6 @@ SetUpLockedPrototype(PropertyDescriptor, $Array( // property descriptor. For a description of the array layout please // see the runtime.cc file. function ConvertDescriptorArrayToDescriptor(desc_array) { - if (desc_array === false) { - throw 'Internal error: invalid desc_array'; - } - if (IS_UNDEFINED(desc_array)) { return UNDEFINED; } @@ -649,9 +645,6 @@ function GetOwnPropertyJS(obj, v) { // If p is not a property on obj undefined is returned. var props = %GetOwnProperty(ToObject(obj), p); - // A false value here means that access checks failed. - if (props === false) return UNDEFINED; - return ConvertDescriptorArrayToDescriptor(props); } @@ -692,11 +685,8 @@ function DefineProxyProperty(obj, p, attributes, should_throw) { // ES5 8.12.9. function DefineObjectProperty(obj, p, desc, should_throw) { - var current_or_access = %GetOwnProperty(ToObject(obj), ToName(p)); - // A false value here means that access checks failed. - if (current_or_access === false) return UNDEFINED; - - var current = ConvertDescriptorArrayToDescriptor(current_or_access); + var current_array = %GetOwnProperty(ToObject(obj), ToName(p)); + var current = ConvertDescriptorArrayToDescriptor(current_array); var extensible = %IsExtensible(ToObject(obj)); // Error handling according to spec. -- 2.7.4