From 7f414b90ab9f96948c11bd5d4f4d925f70969266 Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Mon, 22 Aug 2016 23:40:01 +0000 Subject: [PATCH] [MemorySSA] Remove unused field. NFC. Given that we're not currently using blocker info, and whether or not we will end up using it it is unclear, don't waste 8 (or 4) bytes of memory per path node. llvm-svn: 279493 --- llvm/lib/Transforms/Utils/MemorySSA.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/llvm/lib/Transforms/Utils/MemorySSA.cpp b/llvm/lib/Transforms/Utils/MemorySSA.cpp index e4acddd..151e606 100644 --- a/llvm/lib/Transforms/Utils/MemorySSA.cpp +++ b/llvm/lib/Transforms/Utils/MemorySSA.cpp @@ -490,9 +490,6 @@ class ClobberWalker { // First. Also note that First and Last are inclusive. MemoryAccess *First; MemoryAccess *Last; - // N.B. Blocker is currently basically unused. The goal is to use it to make - // cache invalidation better, but we're not there yet. - MemoryAccess *Blocker; Optional Previous; DefPath(const MemoryLocation &Loc, MemoryAccess *First, MemoryAccess *Last, @@ -834,8 +831,7 @@ class ClobberWalker { // FIXME: This is broken, because the Blocker may be reported to be // liveOnEntry, and we'll happily wait for that to disappear (read: never) - // For the moment, this is fine, since we do basically nothing with - // blocker info. + // For the moment, this is fine, since we do nothing with blocker info. if (Optional Blocker = getBlockingAccess( Target, PausedSearches, NewPaused, TerminatedPaths)) { // Cache our work on the blocking node, since we know that's correct. @@ -850,7 +846,6 @@ class ClobberWalker { DefPath &CurNode = *Iter; assert(CurNode.Last == Current); - CurNode.Blocker = Blocker->Clobber; // Two things: // A. We can't reliably cache all of NewPaused back. Consider a case -- 2.7.4