From 7eca91d4781bb3df941f25c30b971dac66ba1b3d Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Sun, 26 Mar 2023 20:15:05 +0200 Subject: [PATCH] predict: Don't emit -Wsuggest-attribute=cold warning for functions which already have that attribute [PR105685] In the following testcase, we predict baz to have cold entry regardless of the user supplied attribute (as it call unconditionally a cold function), but still issue a -Wsuggest-attribute=cold warning despite it having that attribute already. The following patch avoids that. 2023-03-26 Jakub Jelinek PR ipa/105685 * predict.cc (compute_function_frequency): Don't call warn_function_cold if function already has cold attribute. * c-c++-common/cold-2.c: New test. --- gcc/predict.cc | 4 +++- gcc/testsuite/c-c++-common/cold-2.c | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/c-c++-common/cold-2.c diff --git a/gcc/predict.cc b/gcc/predict.cc index 851117e..a0dc409 100644 --- a/gcc/predict.cc +++ b/gcc/predict.cc @@ -4033,7 +4033,9 @@ compute_function_frequency (void) } node->frequency = NODE_FREQUENCY_UNLIKELY_EXECUTED; - warn_function_cold (current_function_decl); + if (lookup_attribute ("cold", DECL_ATTRIBUTES (current_function_decl)) + == NULL) + warn_function_cold (current_function_decl); if (ENTRY_BLOCK_PTR_FOR_FN (cfun)->count.ipa() == profile_count::zero ()) return; FOR_EACH_BB_FN (bb, cfun) diff --git a/gcc/testsuite/c-c++-common/cold-2.c b/gcc/testsuite/c-c++-common/cold-2.c new file mode 100644 index 0000000..7f78496 --- /dev/null +++ b/gcc/testsuite/c-c++-common/cold-2.c @@ -0,0 +1,19 @@ +/* PR ipa/105685 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -Wsuggest-attribute=cold" } */ + +extern void foo (char *, char const *, int); + +__attribute__((cold)) char * +bar (int x) +{ + static char b[42]; + foo (b, "foo", x); + return b; +} + +__attribute__((cold)) char * +baz (int x) /* { dg-bogus "function might be candidate for attribute 'cold'" } */ +{ + return bar (x); +} -- 2.7.4