From 7e586c017f3b04847a1e859d9322cac4fcd74e57 Mon Sep 17 00:00:00 2001 From: Julien Moutte Date: Thu, 29 Jan 2004 10:35:29 +0000 Subject: [PATCH] docs/random/ds/element-checklist: Adding some notes about src events. Original commit message from CVS: 2004-01-29 Julien MOUTTE * docs/random/ds/element-checklist: Adding some notes about src events. --- ChangeLog | 5 +++++ docs/random/ds/element-checklist | 12 ++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7943a14..dc39cb4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2004-01-29 Julien MOUTTE + + * docs/random/ds/element-checklist: Adding some notes about src + events. + 2004-01-29 Ronald Bultje * docs/random/mimetypes: diff --git a/docs/random/ds/element-checklist b/docs/random/ds/element-checklist index c15bb8f..fcac4e4 100644 --- a/docs/random/ds/element-checklist +++ b/docs/random/ds/element-checklist @@ -23,6 +23,16 @@ Make sure that each .c file includes config.h (conditionally on HAVE_CONFIG_H). Make sure that each .h file does _not_ include config.h. +4. src event handling + +Every element having multiple sink pads or having a specific need to handle +src events in a different manner than the default event handler should do that +correctly. Correctly means that : + +- It should not leak the event if it is handled (gst_event_unref) +- It should call return gst_pad_event_default (pad, event) for all non handled +localy events. Otherwise it breaks navigation, seeking, etc... +- it should return a TRUE/FALSE boolean if the localy handled event was handled. @@ -31,5 +41,3 @@ other ideas: - plugins should avoid using gst_caps_to_string() in debug statement. They should use %"GST_PTR_FORMAT" instead. Check all usage for leaks. - - -- 2.7.4