From 7e5682ee6201c17b07de326806cf2d19d2f8935a Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Wed, 28 Apr 2021 11:54:00 +0200 Subject: [PATCH] [ADT] Make TrackingStatistic's ctor constexpr This lets clang diagnose unused statistics, so remove them. --- llvm/include/llvm/ADT/Statistic.h | 3 ++- llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp | 3 --- llvm/lib/Transforms/IPO/Attributor.cpp | 2 -- llvm/lib/Transforms/Utils/BuildLibCalls.cpp | 1 - 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/llvm/include/llvm/ADT/Statistic.h b/llvm/include/llvm/ADT/Statistic.h index de7dabc..528d2cd 100644 --- a/llvm/include/llvm/ADT/Statistic.h +++ b/llvm/include/llvm/ADT/Statistic.h @@ -55,7 +55,8 @@ public: std::atomic Value; std::atomic Initialized; - TrackingStatistic(const char *DebugType, const char *Name, const char *Desc) + constexpr TrackingStatistic(const char *DebugType, const char *Name, + const char *Desc) : DebugType(DebugType), Name(Name), Desc(Desc), Value(0), Initialized(false) {} diff --git a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp index 5385793..ead953c 100644 --- a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp +++ b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp @@ -201,9 +201,6 @@ using namespace llvm; #define DEBUG_TYPE "livedebugvalues" -STATISTIC(NumInserted, "Number of DBG_VALUE instructions inserted"); -STATISTIC(NumRemoved, "Number of DBG_VALUE instructions removed"); - // Act more like the VarLoc implementation, by propagating some locations too // far and ignoring some transfers. static cl::opt EmulateOldLDV("emulate-old-livedebugvalues", cl::Hidden, diff --git a/llvm/lib/Transforms/IPO/Attributor.cpp b/llvm/lib/Transforms/IPO/Attributor.cpp index 665abfa..cc8804f 100644 --- a/llvm/lib/Transforms/IPO/Attributor.cpp +++ b/llvm/lib/Transforms/IPO/Attributor.cpp @@ -63,8 +63,6 @@ STATISTIC(NumAttributesValidFixpoint, "Number of abstract attributes in a valid fixpoint state"); STATISTIC(NumAttributesManifested, "Number of abstract attributes manifested in IR"); -STATISTIC(NumAttributesFixedDueToRequiredDependences, - "Number of abstract attributes fixed due to required dependences"); // TODO: Determine a good default value. // diff --git a/llvm/lib/Transforms/Utils/BuildLibCalls.cpp b/llvm/lib/Transforms/Utils/BuildLibCalls.cpp index 33740ea..0d685c0 100644 --- a/llvm/lib/Transforms/Utils/BuildLibCalls.cpp +++ b/llvm/lib/Transforms/Utils/BuildLibCalls.cpp @@ -44,7 +44,6 @@ STATISTIC(NumSExtArg, "Number of arguments inferred as signext"); STATISTIC(NumReadOnlyArg, "Number of arguments inferred as readonly"); STATISTIC(NumNoAlias, "Number of function returns inferred as noalias"); STATISTIC(NumNoUndef, "Number of function returns inferred as noundef returns"); -STATISTIC(NumNonNull, "Number of function returns inferred as nonnull returns"); STATISTIC(NumReturnedArg, "Number of arguments inferred as returned"); STATISTIC(NumWillReturn, "Number of functions inferred as willreturn"); -- 2.7.4