From 7e4697ec983d31bcae25cb7049afd306c3f09219 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 23 Nov 2016 18:26:29 +0200 Subject: [PATCH] rtspdefs: Assert on the excepted MD5 digest string length CID 1394494. --- gst-libs/gst/rtsp/gstrtspdefs.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gst-libs/gst/rtsp/gstrtspdefs.c b/gst-libs/gst/rtsp/gstrtspdefs.c index c00e320..fa1fd05 100644 --- a/gst-libs/gst/rtsp/gstrtspdefs.c +++ b/gst-libs/gst/rtsp/gstrtspdefs.c @@ -543,7 +543,8 @@ auth_digest_compute_response_md5 (const gchar * method, const gchar * realm, g_checksum_update (md5_context, (const guchar *) ":", 1); g_checksum_update (md5_context, (const guchar *) password, strlen (password)); digest_string = g_checksum_get_string (md5_context); - memcpy (hex_a1, digest_string, strlen (digest_string)); + g_assert (strlen (digest_string) == 32); + memcpy (hex_a1, digest_string, 32); g_checksum_reset (md5_context); /* compute A2 */ @@ -551,7 +552,8 @@ auth_digest_compute_response_md5 (const gchar * method, const gchar * realm, g_checksum_update (md5_context, (const guchar *) ":", 1); g_checksum_update (md5_context, (const guchar *) uri, strlen (uri)); digest_string = g_checksum_get_string (md5_context); - memcpy (hex_a2, digest_string, strlen (digest_string)); + g_assert (strlen (digest_string) == 32); + memcpy (hex_a2, digest_string, 32); /* compute KD */ g_checksum_reset (md5_context); -- 2.7.4