From 7d6cf17498625ef7dd3c3af6e3d789ff51465894 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 1 Dec 2016 17:38:33 +0200 Subject: [PATCH] matroskademux: Fix memory leak when parsing attachments gst_tag_image_data_to_image_sample() does not take ownership of the passed memory, so don't set it to NULL to allow us to free it later. https://bugzilla.gnome.org/show_bug.cgi?id=775472 --- gst/matroska/matroska-read-common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gst/matroska/matroska-read-common.c b/gst/matroska/matroska-read-common.c index 4103848..39bc2db 100644 --- a/gst/matroska/matroska-read-common.c +++ b/gst/matroska/matroska-read-common.c @@ -625,10 +625,9 @@ gst_matroska_read_common_parse_attached_file (GstMatroskaReadCommon * common, tagsample = gst_tag_image_data_to_image_sample (data, datalen, image_type); - if (!tagsample) + if (!tagsample) { image_type = GST_TAG_IMAGE_TYPE_NONE; - else { - data = NULL; + } else { tagbuffer = gst_buffer_ref (gst_sample_get_buffer (tagsample)); caps = gst_caps_ref (gst_sample_get_caps (tagsample)); info = gst_structure_copy (gst_sample_get_info (tagsample)); -- 2.7.4