From 7d3858a14da8e3b9ec6a36e9c2e5c627e77b9df6 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Mon, 22 Aug 2011 09:06:53 +0100 Subject: [PATCH] textoverlay: fix text buffer leak Make sure to always unref the input text buffer. Reported by bcxa.sz@gmail.com. https://bugzilla.gnome.org/show_bug.cgi?id=657049 --- ext/pango/gsttextoverlay.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ext/pango/gsttextoverlay.c b/ext/pango/gsttextoverlay.c index 675479d..e3e3b56 100644 --- a/ext/pango/gsttextoverlay.c +++ b/ext/pango/gsttextoverlay.c @@ -2422,7 +2422,7 @@ gst_text_overlay_text_chain (GstPad * pad, GstBuffer * buffer) gst_segment_set_last_stop (&overlay->text_segment, GST_FORMAT_TIME, clip_start); - overlay->text_buffer = buffer; + overlay->text_buffer = gst_buffer_ref (buffer); /* That's a new text buffer we need to render */ overlay->need_render = TRUE; @@ -2434,6 +2434,7 @@ gst_text_overlay_text_chain (GstPad * pad, GstBuffer * buffer) beach: + gst_buffer_unref (buffer); return ret; } -- 2.7.4