From 7d35a07f1aca7a49fb9ba2fcec81646bec2ce6b5 Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Tue, 19 Jan 2016 23:22:35 +0100 Subject: [PATCH] Revert "videoencoder: Release video frame when ->handle return ERROR or DROPPED" This reverts commit 63517d0ed348784cce4ab4b295c2c0f1b78baa81. It was wrong ref counting wise and we decided to deprecated DROPPED return value https://bugzilla.gnome.org/show_bug.cgi?id=760666 --- gst-libs/gst/video/gstvideoencoder.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/gst-libs/gst/video/gstvideoencoder.c b/gst-libs/gst/video/gstvideoencoder.c index fc0c9a9..c45bc7d 100644 --- a/gst-libs/gst/video/gstvideoencoder.c +++ b/gst-libs/gst/video/gstvideoencoder.c @@ -212,9 +212,7 @@ static void gst_video_encoder_init (GstVideoEncoder * enc, GstVideoEncoderClass * klass); static void gst_video_encoder_finalize (GObject * object); -static void -gst_video_encoder_release_frame (GstVideoEncoder * enc, - GstVideoCodecFrame * frame); + static gboolean gst_video_encoder_setcaps (GstVideoEncoder * enc, GstCaps * caps); static GstCaps *gst_video_encoder_sink_getcaps (GstVideoEncoder * encoder, @@ -1481,11 +1479,6 @@ gst_video_encoder_chain (GstPad * pad, GstObject * parent, GstBuffer * buf) ret = klass->handle_frame (encoder, frame); - if (ret == GST_VIDEO_ENCODER_FLOW_DROPPED || ret == GST_FLOW_ERROR) { - GST_INFO_OBJECT (encoder, "Dropping frame %p", frame); - gst_video_encoder_release_frame (encoder, frame); - } - done: GST_VIDEO_ENCODER_STREAM_UNLOCK (encoder); -- 2.7.4