From 7cf17a9e5e70ac8e1d6d1c57807ea3a65f42113b Mon Sep 17 00:00:00 2001 From: verwaest Date: Mon, 24 Nov 2014 11:16:16 -0800 Subject: [PATCH] Don't double smi-tag the mask used to check read-only / field mode in the dictionary-store-stub on X64 BUG= Review URL: https://codereview.chromium.org/757673002 Cr-Commit-Position: refs/heads/master@{#25493} --- src/ic/x64/ic-x64.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ic/x64/ic-x64.cc b/src/ic/x64/ic-x64.cc index f125322..c734560 100644 --- a/src/ic/x64/ic-x64.cc +++ b/src/ic/x64/ic-x64.cc @@ -119,9 +119,8 @@ static void GenerateDictionaryStore(MacroAssembler* masm, Label* miss_label, NameDictionary::kElementsStartIndex * kPointerSize; const int kDetailsOffset = kElementsStartOffset + 2 * kPointerSize; const int kTypeAndReadOnlyMask = - (PropertyDetails::TypeField::kMask | - PropertyDetails::AttributesField::encode(READ_ONLY)) - << kSmiTagSize; + PropertyDetails::TypeField::kMask | + PropertyDetails::AttributesField::encode(READ_ONLY); __ Test(Operand(elements, scratch1, times_pointer_size, kDetailsOffset - kHeapObjectTag), Smi::FromInt(kTypeAndReadOnlyMask)); -- 2.7.4