From 7c561be5192b440c9e220ef04dcac0567f022c91 Mon Sep 17 00:00:00 2001 From: "ager@chromium.org" Date: Mon, 28 Feb 2011 13:29:05 +0000 Subject: [PATCH] Remove Error.prototype.toStrings prototype property. I did not use the helper function for adding this builtin function which meant that I missed the removal of the prototype property. BUG= TEST= Review URL: http://codereview.chromium.org/6588050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6971 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/messages.js | 4 ++-- test/mjsunit/regress/regress-1218.js | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) create mode 100644 test/mjsunit/regress/regress-1218.js diff --git a/src/messages.js b/src/messages.js index b7e57aa..3f73706 100644 --- a/src/messages.js +++ b/src/messages.js @@ -1059,8 +1059,8 @@ function errorToString() { } } -%FunctionSetName(errorToString, 'toString'); -%SetProperty($Error.prototype, 'toString', errorToString, DONT_ENUM); + +InstallFunctions($Error.prototype, DONT_ENUM, ['toString', errorToString]); // Boilerplate for exceptions for stack overflows. Used from // Top::StackOverflow(). diff --git a/test/mjsunit/regress/regress-1218.js b/test/mjsunit/regress/regress-1218.js new file mode 100644 index 0000000..dd036ed --- /dev/null +++ b/test/mjsunit/regress/regress-1218.js @@ -0,0 +1,29 @@ +// Copyright 2011 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Builtin functions should not have prototype objects. +assertFalse(Error.prototype.toString.hasOwnProperty("prototype")); -- 2.7.4