From 7c4814306d8a1460b28e9042d95697eadf3e8df0 Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Mon, 10 Sep 2018 22:08:57 +0000 Subject: [PATCH] [ORC] Simplify LLJIT::Create by removing the ExecutionSession parameter. The Create method can just construct the ExecutionSession, rather than having the client pass it in. llvm-svn: 341872 --- llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h | 6 ++---- llvm/lib/ExecutionEngine/Orc/LLJIT.cpp | 12 ++++++------ llvm/tools/lli/lli.cpp | 4 +--- 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h b/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h index aced03f..6e9490b 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h @@ -31,8 +31,7 @@ class LLJIT { public: /// Create an LLJIT instance. static Expected> - Create(std::unique_ptr ES, - std::unique_ptr TM, DataLayout DL); + Create(std::unique_ptr TM, DataLayout DL); /// Returns a reference to the ExecutionSession for this JIT instance. ExecutionSession &getExecutionSession() { return *ES; } @@ -117,8 +116,7 @@ class LLLazyJIT : public LLJIT { public: /// Create an LLLazyJIT instance. static Expected> - Create(std::unique_ptr ES, - std::unique_ptr TM, DataLayout DL, LLVMContext &Ctx); + Create(std::unique_ptr TM, DataLayout DL, LLVMContext &Ctx); /// Set an IR transform (e.g. pass manager pipeline) to run on each function /// when it is compiled. diff --git a/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp b/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp index b463771..464b1e2 100644 --- a/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp +++ b/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp @@ -16,10 +16,9 @@ namespace llvm { namespace orc { Expected> -LLJIT::Create(std::unique_ptr ES, - std::unique_ptr TM, DataLayout DL) { - return std::unique_ptr( - new LLJIT(std::move(ES), std::move(TM), std::move(DL))); +LLJIT::Create(std::unique_ptr TM, DataLayout DL) { + return std::unique_ptr(new LLJIT(llvm::make_unique(), + std::move(TM), std::move(DL))); } Error LLJIT::defineAbsolute(StringRef Name, JITEvaluatedSymbol Sym) { @@ -91,9 +90,10 @@ void LLJIT::recordCtorDtors(Module &M) { } Expected> -LLLazyJIT::Create(std::unique_ptr ES, - std::unique_ptr TM, DataLayout DL, +LLLazyJIT::Create(std::unique_ptr TM, DataLayout DL, LLVMContext &Ctx) { + auto ES = llvm::make_unique(); + const Triple &TT = TM->getTargetTriple(); auto CCMgr = createLocalCompileCallbackManager(TT, *ES, 0); diff --git a/llvm/tools/lli/lli.cpp b/llvm/tools/lli/lli.cpp index 6686084..b88036e 100644 --- a/llvm/tools/lli/lli.cpp +++ b/llvm/tools/lli/lli.cpp @@ -758,9 +758,7 @@ int runOrcLazyJIT(const char *ProgName) { : None); auto TM = ExitOnErr(TMD.createTargetMachine()); auto DL = TM->createDataLayout(); - auto ES = llvm::make_unique(); - auto J = - ExitOnErr(orc::LLLazyJIT::Create(std::move(ES), std::move(TM), DL, Ctx)); + auto J = ExitOnErr(orc::LLLazyJIT::Create(std::move(TM), DL, Ctx)); auto Dump = createDebugDumper(); -- 2.7.4