From 7c3733d5defb5428ddfeefae6d80fcbcc253e7ef Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 2 Oct 2018 12:35:37 +0200 Subject: [PATCH] pid1: remove unnecessary error reassignment LGTM was complaining: > Comparison is always true because r >= 0. --- src/core/manager.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index 5baa30d..c361a1e 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -3459,9 +3459,7 @@ int manager_reload(Manager *m) { m->uid_refs = hashmap_free(m->uid_refs); m->gid_refs = hashmap_free(m->gid_refs); - q = lookup_paths_init(&m->lookup_paths, m->unit_file_scope, 0, NULL); - if (q < 0 && r >= 0) - r = q; + r = lookup_paths_init(&m->lookup_paths, m->unit_file_scope, 0, NULL); q = manager_run_environment_generators(m); if (q < 0 && r >= 0) -- 2.7.4