From 7c08c4c54fcfe6d3c4509e5c583cbb38723f9237 Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Tue, 31 Dec 2013 21:57:53 -0700 Subject: [PATCH] regen/warnings.pl: Add comments These note that warnings categories should be independent in the calls to ckWARN() and packWARN() type macros. --- regen/warnings.pl | 8 ++++++++ warnings.h | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/regen/warnings.pl b/regen/warnings.pl index acca0d0..e8dcf4a 100644 --- a/regen/warnings.pl +++ b/regen/warnings.pl @@ -354,6 +354,10 @@ print $warn <<'EOM'; char)) #define ckWARN(w) Perl_ckwarn(aTHX_ packWARN(w)) + +/* The w1, w2 ... should be independent warnings categories; one shouldn't be + * a subcategory of any other */ + #define ckWARN2(w1,w2) Perl_ckwarn(aTHX_ packWARN2(w1,w2)) #define ckWARN3(w1,w2,w3) Perl_ckwarn(aTHX_ packWARN3(w1,w2,w3)) #define ckWARN4(w1,w2,w3,w4) Perl_ckwarn(aTHX_ packWARN4(w1,w2,w3,w4)) @@ -366,6 +370,10 @@ print $warn <<'EOM'; #define WARNshift 8 #define packWARN(a) (a ) + +/* The a, b, ... should be independent warnings categories; one shouldn't be + * a subcategory of any other */ + #define packWARN2(a,b) ((a) | ((b)<<8) ) #define packWARN3(a,b,c) ((a) | ((b)<<8) | ((c)<<16) ) #define packWARN4(a,b,c,d) ((a) | ((b)<<8) | ((c)<<16) | ((d) <<24)) diff --git a/warnings.h b/warnings.h index 7455a6c..929b94f 100644 --- a/warnings.h +++ b/warnings.h @@ -116,6 +116,10 @@ char)) #define ckWARN(w) Perl_ckwarn(aTHX_ packWARN(w)) + +/* The w1, w2 ... should be independent warnings categories; one shouldn't be + * a subcategory of any other */ + #define ckWARN2(w1,w2) Perl_ckwarn(aTHX_ packWARN2(w1,w2)) #define ckWARN3(w1,w2,w3) Perl_ckwarn(aTHX_ packWARN3(w1,w2,w3)) #define ckWARN4(w1,w2,w3,w4) Perl_ckwarn(aTHX_ packWARN4(w1,w2,w3,w4)) @@ -128,6 +132,10 @@ #define WARNshift 8 #define packWARN(a) (a ) + +/* The a, b, ... should be independent warnings categories; one shouldn't be + * a subcategory of any other */ + #define packWARN2(a,b) ((a) | ((b)<<8) ) #define packWARN3(a,b,c) ((a) | ((b)<<8) | ((c)<<16) ) #define packWARN4(a,b,c,d) ((a) | ((b)<<8) | ((c)<<16) | ((d) <<24)) -- 2.7.4