From 7b8690d78b57e47077e61e4c3d7e1fa5613f1793 Mon Sep 17 00:00:00 2001 From: "Juan A. Suarez Romero" Date: Wed, 20 Jun 2018 18:37:58 +0200 Subject: [PATCH] Increase threshold GLES3 blend tests The threshold used in dEQP-GLES3.functional.fragment_ops.blend.* is computed using a non-scientific ad hoc formula. As stated in a comment, when using few color bits, the blend operations brings extra inaccuracy, which requires to increase the threshold. Apparently, the current threshold value is not enough when using a RGB565 configuration, and it should be increased. Moreover, the threshold used in GLES2 blend tests is a bit bigger, and using this threshold for the GLES3 blend tests fixes the problems with RGB565. Thus this commit applies the GLES2 blend tests threshold to GLES3 tests. Affects: dEQP-GLES3.functional.fragment_ops.blend.default_framebuffer.* Components: OpenGL VK-GL-CTS issue: 1230 Change-Id: I7269768a9591fc70532312d8cc13481252a6f6e2 --- modules/gles3/functional/es3fBlendTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/gles3/functional/es3fBlendTests.cpp b/modules/gles3/functional/es3fBlendTests.cpp index f074b22..6d6ab3f 100644 --- a/modules/gles3/functional/es3fBlendTests.cpp +++ b/modules/gles3/functional/es3fBlendTests.cpp @@ -325,7 +325,7 @@ BlendCase::IterateResult BlendCase::iterate (void) } UVec4 compareThreshold = (m_useSrgbFbo ? tcu::PixelFormat(8, 8, 8, 8) : m_context.getRenderTarget().getPixelFormat()).getColorThreshold().toIVec().asUint() - * UVec4(5) / UVec4(2) + UVec4(m_useSrgbFbo ? 5 : 2); // \note Non-scientific ad hoc formula. Need big threshold when few color bits; blending brings extra inaccuracy. + * UVec4(5) / UVec4(2) + UVec4(m_useSrgbFbo ? 5 : 3); // \note Non-scientific ad hoc formula. Need big threshold when few color bits; blending brings extra inaccuracy. bool comparePass = tcu::intThresholdCompare(m_testCtx.getLog(), "CompareResult", "Image Comparison Result", referenceImg.getAccess(), renderedImg.getAccess(), -- 2.7.4