From 7b834cb0b36c47970999b2f33c9da912dbbbc722 Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Fri, 24 Apr 2015 14:16:24 -0300 Subject: [PATCH] wrappercamerabinsrc: error out if source fails to prepare for capture Post an error when preparing the image capture through photography interface fails --- gst/camerabin2/gstwrappercamerabinsrc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gst/camerabin2/gstwrappercamerabinsrc.c b/gst/camerabin2/gstwrappercamerabinsrc.c index 84ff388..289feba 100644 --- a/gst/camerabin2/gstwrappercamerabinsrc.c +++ b/gst/camerabin2/gstwrappercamerabinsrc.c @@ -824,13 +824,16 @@ start_image_capture (GstPad * pad, GstPadProbeInfo * info, gpointer udata) } if (photography) { - gst_element_set_state (self->src_vid_src, GST_STATE_PLAYING); GST_DEBUG_OBJECT (self, "prepare image capture caps %" GST_PTR_FORMAT, self->image_capture_caps); if (!gst_photography_prepare_for_capture (photography, (GstPhotographyCapturePrepared) img_capture_prepared, - self->image_capture_caps, self)) - self->image_capture_count = 0; /* TODO post an error */ + self->image_capture_caps, self)) { + GST_ELEMENT_ERROR (self, CORE, NEGOTIATION, + ("Failed to prepare image capture"), + ("Prepare capture call didn't succeed for the given caps")); + self->image_capture_count = 0; + } gst_object_unref (photography); } else { gst_wrapper_camera_bin_reset_video_src_caps (self, -- 2.7.4