From 7b6dd265ce8320fee8741ec86edae5d40d7b7b86 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sat, 8 May 2021 13:03:17 -0400 Subject: [PATCH] [lld/mac] Copy some of the commit message of d5a70db193 into a comment --- lld/MachO/UnwindInfoSection.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lld/MachO/UnwindInfoSection.cpp b/lld/MachO/UnwindInfoSection.cpp index 76502bf..a9f0bbd 100644 --- a/lld/MachO/UnwindInfoSection.cpp +++ b/lld/MachO/UnwindInfoSection.cpp @@ -306,6 +306,9 @@ template void UnwindInfoSectionImpl::finalize() { // Dead-stripped functions get a functionAddress of UINT64_MAX in // relocateCompactUnwind(). Filter them out here. + // FIXME: This doesn't yet collect associated data like LSDAs kept + // alive only by a now-removed CompactUnwindEntry or other comdat-like + // data (`kindNoneGroupSubordinate*` in ld64). CompactUnwindEntry tombstone; tombstone.functionAddress = static_cast(UINT64_MAX); cuPtrVector.erase( -- 2.7.4