From 7b211ff92482379aa34c0a217e2aeded5713b2d5 Mon Sep 17 00:00:00 2001 From: Anup Patel Date: Fri, 20 Mar 2020 16:44:38 +0530 Subject: [PATCH] include: sbi_platform: Remove priv parameter from hart_start() callback The priv parameter in hart_start() platform callback is redundant hence we remove it. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_platform.h | 14 ++++++-------- lib/sbi/sbi_hsm.c | 2 +- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h index c47ab46..847e174 100644 --- a/include/sbi/sbi_platform.h +++ b/include/sbi/sbi_platform.h @@ -138,8 +138,8 @@ struct sbi_platform_operations { /** Exit platform timer for current HART */ void (*timer_exit)(void); - /** Bringup the given hart from previous stage **/ - int (*hart_start)(u32 hartid, ulong saddr, ulong priv); + /** Bringup the given hart */ + int (*hart_start)(u32 hartid, ulong saddr); /** * Stop the current hart from running. This call doesn't expect to * return if success. @@ -346,18 +346,16 @@ static inline bool sbi_platform_hart_invalid(const struct sbi_platform *plat, * a generic WFI based approach will be used to start/stop a hart in OpenSBI. * * @param plat pointer to struct sbi_platform - * @param hartid Hart ID - * @param saddr Physical address in supervisor mode for hart to jump after - * OpenSBI - * @param priv A private context data from the caller + * @param hartid HART id + * @param saddr M-mode start physical address for the HART * * @return 0 if sucessful and negative error code on failure */ static inline int sbi_platform_hart_start(const struct sbi_platform *plat, - u32 hartid, ulong saddr, ulong priv) + u32 hartid, ulong saddr) { if (plat && sbi_platform_ops(plat)->hart_start) - return sbi_platform_ops(plat)->hart_start(hartid, saddr, priv); + return sbi_platform_ops(plat)->hart_start(hartid, saddr); return SBI_ENOTSUPP; } diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index 10316c5..c896f79 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -240,7 +240,7 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, u32 hartid, if (sbi_platform_has_hart_hotplug(plat) || (sbi_platform_has_hart_secondary_boot(plat) && !init_count)) { return sbi_platform_hart_start(plat, hartid, - scratch->warmboot_addr, priv); + scratch->warmboot_addr); } else { sbi_platform_ipi_send(plat, hartid); } -- 2.7.4