From 7af6452927227a966da8b357c41fa9f36ea42215 Mon Sep 17 00:00:00 2001 From: George Rimar Date: Tue, 30 Aug 2016 09:39:36 +0000 Subject: [PATCH] [ELF] - Use early return. NFC. This addresses forgotten review comment for r280067: "[ELF] - Versionscript: support wildcards for extern "c++" tag." llvm-svn: 280068 --- lld/ELF/SymbolTable.cpp | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lld/ELF/SymbolTable.cpp b/lld/ELF/SymbolTable.cpp index 410a8f3c15b1..0f9a14dc72ca 100644 --- a/lld/ELF/SymbolTable.cpp +++ b/lld/ELF/SymbolTable.cpp @@ -676,16 +676,17 @@ template void SymbolTable::scanVersionScript() { // Handle wildcards. for (size_t I = Config->VersionDefinitions.size() - 1; I != (size_t)-1; --I) { VersionDefinition &V = Config->VersionDefinitions[I]; - for (SymbolVersion &Sym : V.Globals) - if (hasWildcard(Sym.Name)) { - std::vector All = - Sym.IsExternCpp ? findAllDemangled(Demangled, Sym.Name) - : findAll(Sym.Name); - - for (SymbolBody *B : All) - if (B->symbol()->VersionId == Config->DefaultSymbolVersion) - B->symbol()->VersionId = V.Id; - } + for (SymbolVersion &Sym : V.Globals) { + if (!hasWildcard(Sym.Name)) + continue; + std::vector All = + Sym.IsExternCpp ? findAllDemangled(Demangled, Sym.Name) + : findAll(Sym.Name); + + for (SymbolBody *B : All) + if (B->symbol()->VersionId == Config->DefaultSymbolVersion) + B->symbol()->VersionId = V.Id; + } } } -- 2.34.1