From 7a7aeb80c90e329f185aed585ffa7420d1d4a8a8 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sat, 5 Nov 2011 20:41:49 +0100 Subject: [PATCH] tests: remove redundant settings of `errexit' shell flag * tests/aclocal-path-install-serial.test: Do not set the `errexit' shell flag, as it is already set by `tests/defs'. * tests/ar-lib2.test: Likewise. * tests/ar-lib3.test: Likewise. * tests/ar-lib4.test: Likewise. * tests/ar-lib5a.test: Likewise. * tests/ar-lib5b.test: Likewise. * tests/ar-lib6a.test: Likewise. * tests/ar-lib6b.test: Likewise. * tests/ar-lib7.test: Likewise. * tests/ar3.test: Likewise. * tests/ar4.test: Likewise. * tests/ar5.test: Likewise. * tests/extra-portability.test: Likewise. * tests/extra-portability2.test: Likewise. * tests/extra-portability3.test: Likewise. * tests/install-info-dir.test: Likewise. * tests/maintmode-configure-msg.test: Likewise. --- ChangeLog | 22 ++++++++++++++++++++++ tests/ar-lib2.test | 2 -- tests/ar-lib3.test | 2 -- tests/ar-lib4.test | 2 -- tests/ar-lib5a.test | 2 -- tests/ar-lib5b.test | 2 -- tests/ar-lib6a.test | 2 -- tests/ar-lib6b.test | 2 -- tests/ar-lib7.test | 2 -- tests/ar3.test | 2 -- tests/ar4.test | 2 -- tests/ar5.test | 2 -- tests/extra-portability.test | 2 -- tests/extra-portability2.test | 2 -- tests/extra-portability3.test | 2 -- tests/install-info-dir.test | 2 -- tests/maintmode-configure-msg.test | 2 -- 17 files changed, 22 insertions(+), 32 deletions(-) diff --git a/ChangeLog b/ChangeLog index 71fde11..3faaf17 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,27 @@ 2011-11-05 Stefano Lattarini + tests: remove redundant settings of `errexit' shell flag + * tests/aclocal-path-install-serial.test: Do not set the + `errexit' shell flag, as it is already set by `tests/defs'. + * tests/ar-lib2.test: Likewise. + * tests/ar-lib3.test: Likewise. + * tests/ar-lib4.test: Likewise. + * tests/ar-lib5a.test: Likewise. + * tests/ar-lib5b.test: Likewise. + * tests/ar-lib6a.test: Likewise. + * tests/ar-lib6b.test: Likewise. + * tests/ar-lib7.test: Likewise. + * tests/ar3.test: Likewise. + * tests/ar4.test: Likewise. + * tests/ar5.test: Likewise. + * tests/extra-portability.test: Likewise. + * tests/extra-portability2.test: Likewise. + * tests/extra-portability3.test: Likewise. + * tests/install-info-dir.test: Likewise. + * tests/maintmode-configure-msg.test: Likewise. + +2011-11-05 Stefano Lattarini + generated tests: avoid extra "FIXME" comments * tests/gen-testsuite-part: Avoid putting too much "FIXME" comments in the generated test scripts, since they end up diff --git a/tests/ar-lib2.test b/tests/ar-lib2.test index 67a64e9..5b697fa 100755 --- a/tests/ar-lib2.test +++ b/tests/ar-lib2.test @@ -18,8 +18,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_PROG_CC AM_PROG_AR diff --git a/tests/ar-lib3.test b/tests/ar-lib3.test index 6bcf6c2..4235bdb 100755 --- a/tests/ar-lib3.test +++ b/tests/ar-lib3.test @@ -18,8 +18,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_PROG_CC AC_PROG_RANLIB diff --git a/tests/ar-lib4.test b/tests/ar-lib4.test index e05a8c2..fb0ca5f 100755 --- a/tests/ar-lib4.test +++ b/tests/ar-lib4.test @@ -19,8 +19,6 @@ required=libtoolize . ./defs || Exit 1 -set -e - cp configure.in X cat >> configure.in << 'END' diff --git a/tests/ar-lib5a.test b/tests/ar-lib5a.test index d1de98b..8c9b6eb 100755 --- a/tests/ar-lib5a.test +++ b/tests/ar-lib5a.test @@ -21,8 +21,6 @@ required=lib . ./defs || Exit 1 -set -e - cat > configure.in << END AC_INIT([$me], [1.0]) AC_CONFIG_AUX_DIR([auxdir]) diff --git a/tests/ar-lib5b.test b/tests/ar-lib5b.test index 52deab5..09742ca 100755 --- a/tests/ar-lib5b.test +++ b/tests/ar-lib5b.test @@ -20,8 +20,6 @@ . ./defs || Exit 1 -set -e - cat > configure.in << END AC_INIT([$me], [1.0]) AC_CONFIG_AUX_DIR([auxdir]) diff --git a/tests/ar-lib6a.test b/tests/ar-lib6a.test index f1b982c..0e04e82 100755 --- a/tests/ar-lib6a.test +++ b/tests/ar-lib6a.test @@ -20,8 +20,6 @@ required=libtoolize . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_PROG_CC AC_PROG_RANLIB diff --git a/tests/ar-lib6b.test b/tests/ar-lib6b.test index 5487add..789691a 100755 --- a/tests/ar-lib6b.test +++ b/tests/ar-lib6b.test @@ -20,8 +20,6 @@ required=libtoolize . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_PROG_CC AC_PROG_RANLIB diff --git a/tests/ar-lib7.test b/tests/ar-lib7.test index 3f758a9..89a279a 100755 --- a/tests/ar-lib7.test +++ b/tests/ar-lib7.test @@ -18,8 +18,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AM_PROG_AR END diff --git a/tests/ar3.test b/tests/ar3.test index 1d5e84e..c8db414 100755 --- a/tests/ar3.test +++ b/tests/ar3.test @@ -19,8 +19,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AC_PROG_CC AM_PROG_AR diff --git a/tests/ar4.test b/tests/ar4.test index ebd8c57..60db9e7 100755 --- a/tests/ar4.test +++ b/tests/ar4.test @@ -18,8 +18,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AM_PROG_AR END diff --git a/tests/ar5.test b/tests/ar5.test index d00f421..8908ca7 100755 --- a/tests/ar5.test +++ b/tests/ar5.test @@ -18,8 +18,6 @@ . ./defs || Exit 1 -set -e - cat >> configure.in << 'END' AM_PROG_AR([echo spy > bad-archiver-interface-detected]) END diff --git a/tests/extra-portability.test b/tests/extra-portability.test index 82f0654..22d3749 100755 --- a/tests/extra-portability.test +++ b/tests/extra-portability.test @@ -22,8 +22,6 @@ . ./defs || Exit 1 -set -e - # We want (almost) complete control over automake options. AUTOMAKE="$am_original_AUTOMAKE --foreign -Werror" diff --git a/tests/extra-portability2.test b/tests/extra-portability2.test index cd8632b..ceaac22 100755 --- a/tests/extra-portability2.test +++ b/tests/extra-portability2.test @@ -19,8 +19,6 @@ . ./defs || Exit 1 -set -e - # We want complete control over automake options. AUTOMAKE=$am_original_AUTOMAKE diff --git a/tests/extra-portability3.test b/tests/extra-portability3.test index 9773b89..125344d 100755 --- a/tests/extra-portability3.test +++ b/tests/extra-portability3.test @@ -19,8 +19,6 @@ . ./defs || Exit 1 -set -e - # We want (almost) complete control over automake options. AUTOMAKE="$am_original_AUTOMAKE --foreign -Werror" diff --git a/tests/install-info-dir.test b/tests/install-info-dir.test index f75b115..b6f410b 100755 --- a/tests/install-info-dir.test +++ b/tests/install-info-dir.test @@ -30,8 +30,6 @@ mkdir bin saved_PATH=$PATH; export saved_PATH PATH=$cwd/bin$PATH_SEPARATOR$PATH; export PATH -set -e - cat >> configure.in <<'END' AC_OUTPUT END diff --git a/tests/maintmode-configure-msg.test b/tests/maintmode-configure-msg.test index f32c4fa..f330bd0 100755 --- a/tests/maintmode-configure-msg.test +++ b/tests/maintmode-configure-msg.test @@ -21,8 +21,6 @@ . ./defs || Exit 1 -set -e - set_maintmode () { rm -rf autom4te*.cache # Just to be sure not to use a stale cache. -- 2.7.4